Ticket #1075: ExecuteAction.patch

tracrpc/ticket.py

@@ -6 +6 @@
-import trac.ticket.model as model
-import trac.ticket.query as query
-from trac.ticket.api import TicketSystem
+from trac.ticket.web_ui import TicketModule
-from trac.ticket.notification import TicketNotifyEmail
-from trac.util.datefmt import utc
-
@@ -27 +28 @@
-        yield ('TICKET_VIEW', ((list,), (list, str)), self.query)
-        yield ('TICKET_VIEW', ((list, xmlrpclib.DateTime),), self.getRecentChanges)
-        yield ('TICKET_VIEW', ((list, int),), self.getAvailableActions)
+        yield ('TICKET_MODIFY', ((list, int, str, str),), self.executeAction)
-        yield ('TICKET_VIEW', ((list, int),), self.get)
-        yield ('TICKET_CREATE', ((int, str, str), (int, str, str, dict), (int, str, str, dict, bool)), self.create)
-        yield ('TICKET_ADMIN', ((list, int, str), (list, int, str, dict), (list, int, str, dict, bool)), self.update)
@@ -67 +69 @@
-        ticketSystem = TicketSystem(self.env)
-        t = model.Ticket(self.env, id)
-        return ticketSystem.get_available_actions(req, t)
+    
+    def executeAction(self, req, id, action, comment):
+        """Executes the given action on the ticket."""
+        ticket = model.Ticket(self.env, id)
+        TicketModule(self.env)._populate(req, ticket)
+        valid = TicketModule(self.env)._validate_ticket(req, ticket)
+        actions = TicketSystem(self.env).get_available_actions(
+                req, ticket)
+        if action not in actions:
+            raise TracError(_('Invalid action "%(name)s"', name=action))
+        field_changes, problems = TicketModule(self.env).get_ticket_changes(req, ticket,
+                                                              action)
+        if problems:
+            valid = False
+            for problem in problems:
+                add_warning(req, problem)
+                add_warning(req,
+                        tag(tag.p('Please review your configuration, '
+                                  'probably starting with'),
+                            tag.pre('[trac]\nworkflow = ...\n'),
+                            tag.p('in your ', tag.tt('trac.ini'), '.'))
+                        )
+        if valid:
+            TicketModule(self.env)._apply_ticket_changes(ticket, field_changes)
+            ticket.save_changes(req.authname or 'anonymous', comment)
-
-    def get(self, req, id):
-        """ Fetch a ticket. Returns [id, time_created, time_changed, attributes]. """