Ticket #1075: ticket-validate.diff

tracrpc/ticket.py

@@ -5 +5 @@
-from tracrpc.util import to_timestamp, to_datetime
-import trac.ticket.model as model
-import trac.ticket.query as query
+from trac.ticket.web_ui import TicketModule
-from trac.ticket.api import TicketSystem
-from trac.ticket.notification import TicketNotifyEmail
-
@@ -28 +29 @@
-        yield ('TICKET_VIEW', ((list, int),), self.getAvailableActions)
-        yield ('TICKET_VIEW', ((list, int),), self.get)
-        yield ('TICKET_CREATE', ((int, str, str), (int, str, str, dict), (int, str, str, dict, bool)), self.create)
-ADMIN
+VIEW
-        yield ('TICKET_ADMIN', ((None, int),), self.delete)
-        yield ('TICKET_VIEW', ((dict, int), (dict, int, int)), self.changeLog)
-        yield ('TICKET_VIEW', ((list, int),), self.listAttachments)
@@ -82 +83 @@
-        t['reporter'] = req.authname or 'anonymous'
-        for k, v in attributes.iteritems():
-            t[k] = v
+        self._validate_ticket(req, t)
-        t.insert()
-
-        if notify:
@@ -101 +103 @@
-        t = model.Ticket(self.env, id)
-        for k, v in attributes.iteritems():
-            t[k] = v
+        self._validate_ticket(req, t)
-        t.save_changes(req.authname or 'anonymous', comment)
-
-        if notify:
@@ -166 +169 @@
-        """ Return a list of all ticket fields fields. """
-        return TicketSystem(self.env).get_ticket_fields()
-
+    def _validate_ticket(self, req, ticket):
+        ticket_module = TicketModule(self.env)
+        req.args['ts'] = str(ticket.time_changed)
+        if not ticket_module._validate_ticket(req, ticket):
+            raise TracError(' '.join(req.warnings) or 'Invalid ticket data or permissions')
+
-
-def ticketModelFactory(cls, cls_attributes):
-    """ Return a class which exports an interface to trac.ticket.model.<cls>. """