Changeset 3503

Show
Ignore:
Timestamp:
04/12/08 10:32:24 (8 months ago)
Author:
bselby
Message:

Issues with Postgres and MySQL fixed

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • peerreviewplugin/branches/2.1-toddler/codereview/ReviewerStruct.py

    r2577 r3503  
    2121 
    2222    #Status of the reviewer's voting capability 
    23     Status = "" 
     23    Status = 0 
    2424 
    2525    #Reviewer's vote 
     
    3636    def save(self, db): 
    3737        #Add information to a new database entry 
    38         query = "INSERT INTO Reviewers VALUES('" + dbEscape(self.IDReview) + "', '" + dbEscape(self.Reviewer) + "','" + dbEscape(self.Status) + "','" + dbEscape(self.Vote) + "')" 
    3938        cursor = db.cursor(); 
    4039        try: 
    41             cursor.execute(query) 
     40            cursor.execute("INSERT INTO Reviewers " 
     41                           "(IDReview, Reviewer, Status, Vote) " 
     42                           "VALUES(%s, %s, %s, %s) ", 
     43                           (self.IDReview, self.Reviewer, self.Status, self.Vote)) 
    4244            db.commit() 
    4345        except: 
    4446            #Update information in existing database entry 
    45             query = "UPDATE Reviewers SET Status = '" + dbEscape(self.Status) + "', Vote = '" + dbEscape(self.Vote) + "' WHERE IDReview = '" + dbEscape(self.IDReview) + "' AND Reviewer = '" + dbEscape(self.Reviewer) + "'" 
    46             cursor.execute(query) 
     47            cursor.execute("UPDATE Reviewers SET " 
     48                           "Status=%s, Vote=%s WHERE IDReview=%s AND Reviewer=%s", 
     49                           (self.Status, self.Vote, self.IDReview, self.Reviewer)) 
    4750            db.commit()