Changeset 3504

Show
Ignore:
Timestamp:
04/12/08 10:32:38 (5 months ago)
Author:
bselby
Message:

Issues with Postgres and MySQL fixed

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • peerreviewplugin/branches/2.1-toddler/codereview/ReviewFilesStruct.py

    r2577 r3504  
    4646        if self.IDFile == "": 
    4747        #Add information to a new database entry 
    48             query = "INSERT INTO ReviewFiles VALUES(NULL,'" + dbEscape(self.IDReview) + "', '" + dbEscape(self.Path) + "','" + dbEscape(self.LineStart) + "','" + dbEscape(self.LineEnd) + "','" + dbEscape(self.Version) + "')" 
    49             cursor.execute(query) 
     48            cursor.execute("INSERT INTO ReviewFiles " 
     49                           "(IDReview, Path, LineStart, LineEnd, Version) " 
     50                           "VALUES (%s, %s, %s, %s, %s) ", 
     51                           (self.IDReview, self.Path, self.LineStart, self.LineEnd, self.Version)) 
     52            self.IDFile = db.get_last_id(cursor, 'ReviewFiles', 'IDFile') 
    5053            db.commit() 
    51             self.IDFile = cursor.lastrowid; 
    5254        else: 
    5355        #Update information in existing database entry 
    54             query = "UPDATE ReviewFiles SET IDReview = '" + dbEscape(self.IDReview) + "', Path = '" + dbEscape(self.Path) + + "', LineStart = '" + dbEscape(self.LineStart) + "', LineEnd = '" + dbEscape(self.LineEnd) + "', Version = '" + dbEscape(self.Version) + "' WHERE IDFile = '" + dbEscape(self.IDFile) + "'" 
    55             cursor.execute(query) 
     56            cursor.execute("UPDATE ReviewFiles SET " 
     57                           "IDReview=%s, Path=%s, LineStart=%s, LineEnd=%s, Version=%s WHERE IDFile=%s", 
     58                           (self.IDReview, self.Path, self.LineStart, self.LineEnd, self.Version, self.IDFile)) 
    5659            db.commit() 
    5760        return self.IDFile