Changeset 3548

Timestamp:

04/24/08 17:36:15 (4 months ago)

Author:

proofek

Message:

peerReviewView templated transformed to genshi

Files:

• peerreviewplugin/branches/2.1-toddler/codereview/peerReviewView.py (modified) (10 diffs)
• peerreviewplugin/branches/2.1-toddler/codereview/templates/peerReviewView.cs (deleted)
• peerreviewplugin/branches/2.1-toddler/codereview/templates/peerReviewView.html (added)

peerreviewplugin/branches/2.1-toddler/codereview/peerReviewView.py

@@ -22 +22 @@
-from trac.web.chrome import add_stylesheet
-import time
+import itertools
-
-class UserbaseModule(Component):
@@ -41 +42 @@
-                                        
-    def process_request(self, req):
+
+        data = {}
-        # check to see if the user is a manager of this page or not
-        if req.perm.has_permission('CODE_REVIEW_MGR'):
-req.hdf
+data
-        else:
-            req.perm.assert_permission('CODE_REVIEW_DEV')
-
-
-
-
-
-
-
-
-
+
-
-        # reviewID argument checking
-        reviewID = req.args.get('Review')
-        if reviewID == None or not reviewID.isdigit():
-req.hdf
-req.hdf
-req.hdf
-
-
-req.hdf
-req.hdf
-req.hdf
-req.hdf['options
+data
+data
+data
+data, 
+
+data
+data
+data
+data['option
-
-        # set up to display the files that are in this review
@@ -85 +80 @@
-            returnfiles.append(newfile)
-            newfile = []
-req.hdf
-req.hdf
-req.hdf
-
-req.hdf
+data
+data
+data
+
+data
-        review = dbBack.getCodeReviewsByID(reviewID)
-        # error if review id does not exist in the database
-        if review == None:
-req.hdf
-req.hdf
-req.hdf
-
+data
+data
+data
+data, 
-
-        # set up the fields that will be displayed on the page
-req.hdf
-req.hdf
-req.hdf
-req.hdf
-req.hdf
-req.hdf
-req.hdf
-req.hdf
-req.hdf
-req.hdf['total_votes_possible'] = float(req.hdf['voteyes']) + float(req.hdf['voteno']) + float(req.hdf
-req.hdf
+data
+data
+data
+data
+data
+data
+data
+data
+data
+data['total_votes_possible'] = float(data['voteyes']) + float(data['voteno']) + float(data
+data
-
-        # figure out whether I can vote on this review or not
-req.hdf
+data
-        if entry != None:
-req.hdf
-req.hdf
-
-req.hdf
+data
+data
+
+data
-
-        #display vote summary only if I have voted or am the author/manager, or if the review is "Ready for inclusion" or "Closed
-req.hdf
-req.hdf['author'] == req.hdf['myname'] or req.hdf['manager'] == '1' or (dbBack.getReviewerEntry(reviewID, req.hdf['myname']) != None and dbBack.getReviewerEntry(reviewID, req.hdf['myname']).Vote != '-1') or req.hdf['status']=="Closed" or req.hdf
-req.hdf
-
-req.hdf
+data
+data['author'] == data['myname'] or data['manager'] == '1' or (dbBack.getReviewerEntry(reviewID, data['myname']) != None and dbBack.getReviewerEntry(reviewID, data['myname']).Vote != '-1') or data['status']=="Closed" or data
+data
+
+data
-
-        rvs = []  # reviewer/vote pairs
@@ -133 +128 @@
-        # if we are the author, list who has voted and who has not.
-        # if we are neither, list the users who are participating in this review. 
-req.hdf
+data
-            for reviewer in reviewers:
-                newrvpair.append(reviewer.Reviewer)
@@ -159 +154 @@
-                newrvpair = []
-
-req.hdf
-req.hdf
+data
+data
-
-
-        # execute based on URL arguments
-        if req.args.get('Vote') == 'yes':
-
+, data['myname']
-        if req.args.get('Vote') == 'no':
-
+, data['myname']
-
-        # process state (Open for review, ready for inclusion, etc.) change by manager
@@ -175 +170 @@
-
-        if req.args.get('Close') == '1':
-
+, data['manager']
-
-        if req.args.get('Inclusion') == '1':
-            self.submit_for_inclusion(reviewID, req)
-
-       
+        
-        add_stylesheet(req, 'common/css/browser.css')
-
+
+
+
+
-                
-    # ITemplateProvider methods
@@ -200 +198 @@
-    # to vote, change the vote type in the review entry struct in the database
-    # and reload the page.
-
-
-
-req.hdf['myname']
+, myname
+
+
+myname
-        if reviewEntry != None:
-            reviewEntry.Vote = type
@@ -225 +223 @@
-                review.Status = "Open for review"
-            review.save(db)
-req.hdf['trac.href.peerReviewView']
+self.env.href.peerReviewView()
-            
-    # If it is confirmed that the user is the author of this review and they
@@ -238 +236 @@
-                review.Status = "Ready for inclusion"
-                review.save(db)
-req.hdf['trac.href.peerReviewView']
+self.env.href.peerReviewView()
-
-    # If the user is confirmed to be the author or manager and tries to close
-    # this review, close it by changing the status of the review to "Closed."
-
+, manager
-        db = self.env.get_db_cnx()
-        dbBack = dbBackend(db)
-        review = dbBack.getCodeReviewsByID(number)
-        # this option available if you are the author or manager of this code review
-req.hdf('Manager') == '1'
+manager == 1
-            review.Status = "Closed"
-            review.save(db)
-req.hdf['trac.href.peerReviewView']
+self.env.href.peerReviewView()
-            
-    # It has already been confirmed that this user is a manager, so this routine
@@ -260 +258 @@
-        review.Status = type
-        review.save(db)
-req.hdf['trac.href.peerReviewView']
+self.env.href.peerReviewView()
-