Changeset 857 for basicfieldvalidationpatch/trac

Timestamp:

06/13/06 13:14:18 (2 years ago)

Author:

sambloomquist

Message:

BasicFieldValidationPatch:

fixes #438

Files:

• basicfieldvalidationpatch/trac/ticket/api.py (modified) (2 diffs)
• basicfieldvalidationpatch/trac/ticket/model.py (modified) (1 diff)
• basicfieldvalidationpatch/trac/ticket/web_ui.py (modified) (2 diffs)

basicfieldvalidationpatch/trac/ticket/api.py

@@ -97 +97 @@
-            fields.append(field)
-
+        # required fields
+        for field in fields:
+            field['required'] = self.config.getbool('ticket', field['name'] + '.required', False)
+
-        for field in self.get_custom_fields():
-            if field['name'] in [f['name'] for f in fields]:
@@ -122 +126 @@
-                'label': self.config.get('ticket-custom', name + '.label') \
-                         or name.capitalize(),
-
+
+
-            }
-            if field['type'] == 'select' or field['type'] == 'radio':

basicfieldvalidationpatch/trac/ticket/model.py

@@ -276 +276 @@
-        return log
-
+    def validate_required_fields(self, args):
+        #Check for required fields
+        for field in self.fields:
+            if field['required'] and not args.get(field['name']):
+                raise TracError(field['name'] + ' is a required field.')
+
-
-class AbstractEnum(object):

basicfieldvalidationpatch/trac/ticket/web_ui.py

@@ -136 +136 @@
-        ticket.values.setdefault('reporter', util.get_reporter_id(req))
-        ticket.populate(req.args)
+        
+        #Check for required fields
+        ticket.validate_required_fields(req.args)
+        
-        ticket.insert(db=db)
-        db.commit()
@@ -316 +320 @@
-        else:
-            req.perm.assert_permission('TICKET_APPEND')
+            
+        #Check for required fields
+        ticket.validate_required_fields(req.args)
-
-        # Mid air collision?