Modify

Opened 2 years ago

Closed 5 weeks ago

#10193 closed enhancement (fixed)

Upgrade t-h.o to Trac 1.0

Reported by: rjollos Owned by: rjollos
Priority: normal Component: TracHacks
Severity: normal Keywords: upgrade
Cc: hasienda, falkb, osimons, stoecker, mitar, jun66j5 Trac Release: 1.0

Description (last modified by rjollos)

The following plugins needed to be upgraded, tested and possibly fixed to work with the upgraded version of Trac.

Plugin Status
AccountManagerPlugin
AcronymsPlugin
AutoWikifyPlugin ✓ Version 0.2 has been tested with Trac 1.0dev
ChangeLogMacro
EmailProcessorMacro
FootNoteMacro
IncludeMacro
IniAdminPlugin Replaced by TracIniAdminPanelPlugin
NewHackMacro Replaced by NewHackPlugin
NewsFlashMacro
PollMacro
RefMacro Integrated into core with Trac 0.10, see t:TracLinks#Linkanchors
SpamFilterPlugin
SvnAuthzAdminPlugin Needs lots of work
TagsPlugin
TicketChangePlugin Integrated into core with Trac 0.12 (permission TICKET_EDIT_COMMENT)
TicketDeletePlugin Integrated into core as option component with Trac 0.12 (tracopt.ticket.deleter)
TocMacro
TracBlogPlugin deprecated, use FullBlogPlugin
FullBlogPlugin ✓, even combined with FullBlogNotificationPlugin
TracHacksPlugin
TracPygmentsPlugin Integrated into core with Trac 0.11. Make sure to install Pygment 1.5
TracRedirect -> ServerSideRedirectPlugin ✓ Version 0.4 has been tested with Trac 1.0dev
WebAdminPlugin Integrated into core with Trac 0.11
XmlRpcPlugin
WikiReplacePlugin Not currently used on t-h.o, but may be added.

Attachments (1)

trachacksplugin-t10193-r13419.diff (14.8 KB) - added by jun66j5 11 months ago.

Download all attachments as: .zip

Change History (103)

comment:1 Changed 2 years ago by rjollos

  • Description modified (diff)

comment:2 Changed 2 years ago by rjollos

  • Description modified (diff)

comment:3 Changed 2 years ago by rjollos

  • Description modified (diff)

Fixed-up the AutoWikifyPlugin. It should be good to go, but I'll add some unit tests this evening for good measure.

comment:4 Changed 2 years ago by rjollos

  • Description modified (diff)
  • Owner changed from otaku42 to rjollos

RefMacro is no longer needed.

comment:5 Changed 2 years ago by rjollos

  • Description modified (diff)

Let's plan to replace all calls to TOC macro with [[PageOutline(2-5,Contents,pullout)]] unless:

  1. Someone steps up with reasonable objections.
  2. Someone steps up to maintain the macro.

Even better than (2), if someone wishes to step-up and maintain TocMacro, why not see if you can get those features pushed to the Trac core? In the future, we can certainly plan to upgrade t-h.o on the release cycle of Trac, so any features pushes to the Trac core will make their way to t-h.o before too long.

comment:6 Changed 2 years ago by rjollos

  • Description modified (diff)

comment:7 Changed 2 years ago by rjollos

  • Summary changed from Upgrade t--h.o to Trac 1.0 to Upgrade t-h.o to Trac 1.0

comment:8 Changed 2 years ago by rjollos

  • Description modified (diff)

Pushed a patch for ServerSideRedirectPlugin this evening in [11890] and did some quick testing with Trac 1.0dev. Seems to be good to go.

comment:9 follow-up: Changed 2 years ago by falkb

What is the news? What are you doing at present?

comment:10 in reply to: ↑ 9 Changed 2 years ago by rjollos

  • Cc osimons added

Replying to falkb:

What is the news? What are you doing at present?

We should have some news in the near future. Everything seems to be moving towards an upgrade and server move, but the details must be working out in the coming days.

comment:11 Changed 2 years ago by falkb

work for me with 1.0.

I just called python setup.py clean bdist_egg on the current SVN checkout and reloaded Trac with the new plugin egg files, used it for a while, checked the logging.

comment:12 follow-up: Changed 2 years ago by falkb

Last edited 5 weeks ago by rjollos (previous) (diff)

comment:13 in reply to: ↑ 12 Changed 2 years ago by anonymous

Replying to falkb:

No, I think that was just a caching problem, fully works now after Browser restart and Apache reload. I tag it for 1.0, too.

comment:14 Changed 2 years ago by hasienda

  • Description modified (diff)
  • Keywords upgrade added

description update according to falkb's comments, added my own work on AccountManagerPlugin

comment:15 follow-up: Changed 2 years ago by falkb

Hi hasienda, You can also sign InitAdminPlugin since it works with 1.0 as well

comment:16 in reply to: ↑ 15 Changed 2 years ago by hasienda

  • Description modified (diff)

Replying to falkb:

Hi hasienda, You can also sign InitAdminPlugin since it works with 1.0 as well

You meant IniAdminPlugin, right? Done so now.

comment:17 Changed 21 months ago by falkb

What is going on with the TH upgrade?

comment:18 follow-up: Changed 21 months ago by rjollos

We all have one or more jobs each and also maintain several plugins. I don't see myself having time to commit to getting the upgrade off the ground until at least the second week of Feb.

comment:19 in reply to: ↑ 18 Changed 21 months ago by falkb

Replying to rjollos:

... until at least the second week of Feb.

I'll try to get some more plugins from the list above tested until then

comment:20 Changed 21 months ago by rjollos

Thanks, that would be great. I'll be looking for when I have most of a weekend clear before embarking on the initial stage of the upgrade, which is to setup a Trac 1.0 version running on a different port, as Michael had done previously for the Trac 0.11 instance. I'll keep you posted as to when I think that might happen. I had hoped to find time over the holidays, but managed to consume myself with other coding tasks.

comment:21 Changed 21 months ago by falkb

I'd go for the Bitnami version which is an all-in-one package and easy to install, and as second step replace its Trac sources with the SVN trunk of Trac. And I hope we get rid of that nasty "TimeoutError: Unable to get database connection within 20 seconds" that is getting worse over the last months.

comment:22 Changed 19 months ago by rjollos

#10939 closed as a duplicate, requesting a Back to Report or Back to Query link after navigating from a report/query to a ticket. I think we get that for free with the Trac 1.0 upgrade.

comment:23 Changed 18 months ago by rjollos

#10986 closed as a duplicate.

comment:24 follow-up: Changed 18 months ago by rjollos

  • Cc stoecker added

I'm dedicating the entire day of Sat April 6th to getting an instance of trac-hacks running Trac 1.0 on port 8080. Since we have several people offering to help test and fix plugin issues, I'll try to coordinate the effort so that we can get the site deployed asap after that.

Last edited 5 weeks ago by rjollos (previous) (diff)

comment:25 Changed 18 months ago by rjollos

  • Status changed from new to assigned

comment:26 follow-up: Changed 18 months ago by stoecker

Some macro notes:

comment:27 in reply to: ↑ 26 Changed 18 months ago by rjollos

Replying to stoecker:

  • TocMacro works with 1.0, so replace is not required for update.

True, replacing it is not required, but it seemed to be a good opportunity to get rid of the macro. Of course, we can get rid of it later on too, if it still works with Trac 1.0.

I'm open to keeping the TocMacro if it will be maintained, and someone can describe reasons we need to have it on trac-hacks. However, the last commit was in 2008 and I don't think anyone is giving it attention anymore.

comment:28 follow-up: Changed 18 months ago by osimons

I'm maintaining TocMacro in the sense that I use it in production and will fix serious bugs if found. However, it is definitely in maintenance-mode as I don't spend time adding features or fixing trivial bugs.

My main use for [[TOC]] is that it can build a combined TOC for any number of pages at the same time, typically used for plugins that split information into subpages. [[PageOutline]] macro will of course be a fine option for single-page input.

comment:29 in reply to: ↑ 28 Changed 18 months ago by rjollos

Replying to osimons:

My main use for [[TOC]] is that it can build a combined TOC for any number of pages at the same time, typically used for plugins that split information into subpages.

That sounds like a good enough use case to keep it around then. The AccountManagerPlugin has a few subpages, and might benefit from using TOC.

comment:30 follow-up: Changed 18 months ago by anonymous

Maybe providing a patch for core, so that this feature gets added as well?

comment:31 in reply to: ↑ 30 Changed 18 months ago by rjollos

Replying to anonymous:

Maybe providing a patch for core, so that this feature gets added as well?

I had similar thoughts, and I think that enhancing the PageOutline macro in the Trac core is a good idea. I have numerous other issues I'm working on in the Trac core though, so I'm unlikely to get to it soon. Hopefully someone else will :)

comment:32 in reply to: ↑ 24 ; follow-up: Changed 18 months ago by rjollos

Replying to rjollos:

I'm dedicating the entire day of Sat April 6th to getting an instance of trac-hacks running Trac 1.0 on port 8080.

I made a little bit of progress over the weekend, but had some thing come up so didn't get as far as I'd hoped. I will try to make progress during the week. Stay tuned!

comment:33 Changed 17 months ago by mitar

  • Cc mitar added

Joining in a bit. I don't know how much time I can have for this but in general I am interested in how to make collaboration on the Internet better. So let's see what we can do here.

comment:34 in reply to: ↑ 32 Changed 17 months ago by falkb

Replying to rjollos:

I made a little bit of progress over the weekend, but had some thing come up so didn't get as far as I'd hoped.

What is exactly meant with progress and which things came up? What is the news? :)

comment:35 Changed 17 months ago by rjollos

Life things came up, and the demands of people that pay my mortgage :)

I have a holiday coming up, so hope to keep that clear to work on the upgrade.

comment:36 Changed 17 months ago by rjollos

#11078 discusses a workaround for attachments that fail to display, and was closed as a duplicate of this ticket.

comment:37 Changed 16 months ago by falkb

Wow! The new version is much faster and looks good :-)

comment:38 follow-ups: Changed 16 months ago by stoecker

Wow. Finally. Thanks.

After login I get that everywhere.

AttributeError: 'TracHacksHtPasswdStore' object has no attribute 'user_email_verification_requested'

P.S. If I can help with the spamfilter, please ask.

comment:39 in reply to: ↑ 38 Changed 16 months ago by rjollos

Replying to stoecker:

Wow. Finally. Thanks.

It hasn't come about the way I intended; I had hoped for a smoother process, but I made some mistakes and here we are. At least it's moving along, is my feeling at the end of a long day.

After login I get that everywhere.

AttributeError: 'TracHacksHtPasswdStore' object has no attribute 'user_email_verification_requested'

Thanks. Steffen is going to take a look at the AccountManagerPlugin configuration tomorrow. It was major upgrade, and I'm sure I don't have the configuration right yet.

P.S. If I can help with the spamfilter, please ask.

I grabbed a bunch of entries from the logs and one of them seemed related to the SpamFilter (comment:1:ticket:11149). It looked pretty minor, if even a problem at all. We are running 0.8.0dev-r11796 (latest from the 1.0 branch as of earlier today).

I'm sure I'll have lots of questions for you regarding the configuration of the SpamFilterPlugin soon.

comment:40 follow-up: Changed 16 months ago by falkb

Is it policy or a configuration issue that commenting a blog entry is not permitted, even logged in?

comment:41 in reply to: ↑ 40 ; follow-up: Changed 16 months ago by osimons

Replying to falkb:

Is it policy or a configuration issue that commenting a blog entry is not permitted, even logged in?

It is a new permission. Just haven't gotten around to adding it before now. Could you please check again and verify?

BTW, I have added it to authenticated users only. I see no particular good reason why we would want anonymous feedback to site issues.

comment:42 in reply to: ↑ 41 ; follow-up: Changed 16 months ago by falkb

Replying to osimons:

Could you please check again and verify?

Works well

BTW, I have added it to authenticated users only. I see no particular good reason why we would want anonymous feedback to site issues.

This would just result in spam. BTW: I'd suggest to protect it with reCAPTCHA even for authenticated users because a spam robot may simply create a TH user first.

comment:43 follow-up: Changed 16 months ago by osimons

I've also enabled the blog spamfilter support, so all comments should also go through the same verification process as ticket and wiki updates.

Let's hope it works - been a while since I've looked at that particular code. Perhaps stoecker can verify the current implementation? See source:fullblogplugin/0.11/tracfullblog/spamfilter.py

comment:44 follow-up: Changed 16 months ago by rjollos

One other small thing is that we seem to have lost the background with the trac-hacks wording. I'll worry about that when I stop spotting broken features and exceptions!

comment:45 in reply to: ↑ 44 Changed 16 months ago by osimons

Replying to rjollos:

One other small thing is that we seem to have lost the background with the trac-hacks wording. I'll worry about that when I stop spotting broken features and exceptions!

Many small things we've lost here, but all is found in the old customization templates - see trac/templates/site_css.cs, site_footer.cs, site_header.cs and friends. I've started a site.html to get this going, and have so far converted site_newticket.cs and site_css.cs into new format. Particularly styles may need to be reviewed with all visual and layout changes since 0.10... At least it loads, so let's tweak it from here.

comment:46 in reply to: ↑ 43 ; follow-up: Changed 16 months ago by osimons

Replying to osimons:

Let's hope it works - been a while since I've looked at that particular code. Perhaps stoecker can verify the current implementation? See source:fullblogplugin/0.11/tracfullblog/spamfilter.py

Huh. Should not blog comments appear under spam monitoring in admin?

comment:47 in reply to: ↑ 46 Changed 16 months ago by stoecker

Replying to osimons:

Replying to osimons:

Let's hope it works - been a while since I've looked at that particular code. Perhaps stoecker can verify the current implementation? See source:fullblogplugin/0.11/tracfullblog/spamfilter.py

Huh. Should not blog comments appear under spam monitoring in admin?

Hmm, depends on the fact if authenticated users are auto-trusted or not. Default is to trust them fully. Code looks good on first inspection.

comment:48 in reply to: ↑ 42 Changed 16 months ago by stoecker

Replying to falkb:

BTW, I have added it to authenticated users only. I see no particular good reason why we would want anonymous feedback to site issues.

This would just result in spam. BTW: I'd suggest to protect it with reCAPTCHA even for authenticated users because a spam robot may simply create a TH user first.

With a fine trained filter there is no need for a standard captcha anymore. Captcha only appears if submissions have been detected as SPAM and users get a chance to override it. T.E.O. and my josm site have approx. !one spam entry each 2-5000 spam submissions. Usually hand-entered spam passing valid captchas or stuff which is human-mad crap, but not really spam. Both sites allow unregistered edits.

comment:49 Changed 16 months ago by rjollos

I moved the repository configuration from trac.ini to the database, and resynced the repository. The configuration is such that the SVN repository URL is now shown in the contextual navigation of the repository browser.

One odd thing is that the resync kept halting, showing no error. Here is the last bit of my shell session:

rjollos@hacks:~$ sudo /srv/trac-hacks.org/pve/bin/trac-admin /srv/trac-hacks.org/trac repository sync ""
Resyncing repository history for (default)...
6072 revisions cached.
Done.
rjollos@hacks:~$ sudo /srv/trac-hacks.org/pve/bin/trac-admin /srv/trac-hacks.org/trac repository sync ""
Resyncing repository history for (default)...
6213 revisions cached.
Done.
rjollos@hacks:~$ sudo /srv/trac-hacks.org/pve/bin/trac-admin /srv/trac-hacks.org/trac repository sync ""
Resyncing repository history for (default)...
6699 revisions cached.
Done.
rjollos@hacks:~$ sudo /srv/trac-hacks.org/pve/bin/trac-admin /srv/trac-hacks.org/trac repository sync ""
Resyncing repository history for (default)...
6762 revisions cached.
Done.
rjollos@hacks:~$ sudo /srv/trac-hacks.org/pve/bin/trac-admin /srv/trac-hacks.org/trac repository sync ""
Resyncing repository history for (default)...
6993 revisions cached.
Done.
rjollos@hacks:~$ sudo /srv/trac-hacks.org/pve/bin/trac-admin /srv/trac-hacks.org/trac repository sync ""
Resyncing repository history for (default)...
7529 revisions cached.
Done.
rjollos@hacks:~$ sudo /srv/trac-hacks.org/pve/bin/trac-admin /srv/trac-hacks.org/trac repository sync ""
Resyncing repository history for (default)...
10111 revisions cached.
Done.
rjollos@hacks:~$ sudo /srv/trac-hacks.org/pve/bin/trac-admin /srv/trac-hacks.org/trac repository sync ""
Resyncing repository history for (default)...
13267 revisions cached.
Done.
rjollos@hacks:~$ sudo /srv/trac-hacks.org/pve/bin/trac-admin /srv/trac-hacks.org/trac repository sync ""
Resyncing repository history for (default)...
13267 revisions cached.
Done.

In the logs, many entries like the following:

2013-06-07 02:04:10,772 Trac[cache] WARNING: Revision 13089 already cached: IntegrityError('duplicate key value violates unique constraint "revision_pk"\n',)
2013-06-07 02:04:13,460 Trac[cache] WARNING: Revision 13204 already cached: IntegrityError('duplicate key value violates unique constraint "revision_pk"\n',)
2013-06-07 02:04:14,328 Trac[cache] WARNING: Revision 13240 already cached: IntegrityError('duplicate key value violates unique constraint "revision_pk"\n',)
2013-06-07 02:04:14,640 Trac[cache] WARNING: Revision 13253 already cached: IntegrityError('duplicate key value violates unique constraint "revision_pk"\n',)

comment:50 follow-ups: Changed 16 months ago by rjollos

The hacks are back on WikiStart now, and the styling looks quite a bit better. I haven't looked closely at the code, but I imagine it is due to a combination of the Trac 1.0 theme and the work of otaku42 on the TracHacksPlugin.

comment:51 in reply to: ↑ 50 Changed 16 months ago by hasienda

Replying to rjollos:

The hacks are back on WikiStart now, and the styling looks quite a bit better. I haven't looked closely at the code, but I imagine it is due to a combination of the Trac 1.0 theme and the work of otaku42 on the TracHacksPlugin.

Great. OTOH, this slows down the front-page to previous lag-times.

This will finally drive me to look at TracHacksPlugin code. Best possible outcome would be a sub-optimal use of TagsPlugin, so that I could redirect calls towards a faster method for retrieving tagged (wiki) resources too. Using a cached list would be another strong option IMHO. We should really push computing effort and resulting response times towards what we had with the listing disabled, and I'm sure, this is possible.

comment:52 in reply to: ↑ 50 ; follow-up: Changed 16 months ago by falkb

Replying to rjollos:

The hacks are back on WikiStart now, and the styling looks quite a bit better. I haven't looked closely at the code, but I imagine it is due to a combination of the Trac 1.0 theme and the work of otaku42 on the TracHacksPlugin.

Currently, I don't see that table of hacks (both cases, logged in and out). Just "Show hacks for releases:" with an "Update" button appears but nothing happens when I click it.

comment:53 in reply to: ↑ 52 ; follow-up: Changed 16 months ago by rjollos

Replying to falkb:

Currently, I don't see that table of hacks (both cases, logged in and out). Just "Show hacks for releases:" with an "Update" button appears but nothing happens when I click it.

I hadn't granted TAGS_VIEW. Sorry about that. You should see it now.

comment:54 Changed 16 months ago by falkb

Wow! Even the main menu item "Tags" suddenly appeared. Thanks.

comment:55 follow-up: Changed 16 months ago by falkb

The tag cloud doesn't contain plugin names. Correct or not?

comment:56 follow-up: Changed 16 months ago by falkb

Now the main menu offers "Wiki", "Timeline", "Browse Source", "View Tickets", "New Ticket", "Search", "Tags", "Blog". Everything on board now or do we still miss some other VIEW permissions?

"Roadmap" for instance is not shown, maybe it's a good idea to create milestones there for tickets regarding to the improvements of trac-hacks.org itself or related tickets (e.g. TracHacksPlugin). This would likely increase the transparency of the TH project.

comment:57 in reply to: ↑ 55 ; follow-ups: Changed 16 months ago by hasienda

Replying to falkb:

The tag cloud doesn't contain plugin names. Correct or not?

How could that be? Hack names are Components here (that cannot be tagged directly by now - pending enhancement), and tags named after plugins are possible but not planned as a general rule yet. Tagging if wiki pages will have to be converted from TagIt macro (old way).

comment:58 in reply to: ↑ 56 ; follow-up: Changed 16 months ago by hasienda

Replying to falkb:

Now the main menu offers "Wiki", "Timeline", "Browse Source", "View Tickets", "New Ticket", "Search", "Tags", "Blog". Everything on board now or do we still miss some other VIEW permissions?

Looks ok, so far. Probably we'll want to hide the /newticket direct link in favor of the per-hack default link in each hack's wiki page, or at least change the link to /newticket?component=TracHacksPlugin as a sensible default for issues not coming from specific plugins.

"Roadmap" for instance is not shown, maybe it's a good idea to create milestones there for tickets regarding to the improvements of trac-hacks.org itself or related tickets (e.g. TracHacksPlugin). This would likely increase the transparency of the TH project.

Doing it just because it could be done is not a hot idea. We have missed something like the roadmap to triage tickets for some plugins, sure. But we've not decided on how to approach it now. I.e. we can't do it without a having real per-hack-milestones and a per-hack-milestone admin interface. Let's go further on that road only after carefully examining the real benefit and after having prepared the required infrastructure.

Please note, that progress bars are no longer tied to the roadmap, and could be embedded in every text-area supporting WikiFormatting:

[[TicketQuery(component=TracHacksPlugin,format=progress)]]

renders as


Many possibilities with Trac 1.0, you see?

comment:59 in reply to: ↑ 57 Changed 16 months ago by rjollos

Replying to hasienda:

Hack names are Components here (that cannot be tagged directly by now - pending enhancement),

Did you have in mind the ability to add tags to Components, or to use the component table as a tag provider with the name column providing the tags? The latter would be somewhat similar to the [tags] ticket_fields option, except that the component table would be the direct source of tags rather than the component field of each ticket.

comment:60 in reply to: ↑ 57 ; follow-up: Changed 16 months ago by anonymous

Replying to hasienda:

Replying to falkb:

The tag cloud doesn't contain plugin names. Correct or not?

How could that be? Hack names are Components here (that cannot be tagged directly by now - pending enhancement), and tags named after plugins are possible but not planned as a general rule yet. Tagging if wiki pages will have to be converted from TagIt macro (old way).

Sorry, I was not clear enough. I just remembered, with the old Trac version, I've seen e.g. TracJsGanttPlugin with a certain font size on the tag cloud page, but now it's vanished there. I just thought it might be due a permission problem.

comment:61 in reply to: ↑ 58 ; follow-up: Changed 16 months ago by rjollos

Replying to hasienda:

Please note, that progress bars are no longer tied to the roadmap, and could be embedded in every text-area supporting WikiFormatting:

[[TicketQuery(component=TracHacksPlugin,format=progress)]]

renders as


That might be a good modification to make to the NewHack template.

How does this look?: BookmarkPlugin#BugsFeatureRequests. The change makes the link to all tickets, including closed ticket, immediately available to the user, so hopefully more users will take advantage of this to search closed tickets as well before opening a new ticket. As part of the change in #10510, I'll make report {10} group tickets by status, though we might be better off using a custom query rather than a report so that a user can easily do further filtering.

Version 0, edited 16 months ago by rjollos (next)

comment:62 in reply to: ↑ 60 Changed 16 months ago by rjollos

Replying to anonymous:

Sorry, I was not clear enough. I just remembered, with the old Trac version, I've seen e.g. TracJsGanttPlugin with a certain font size on the tag cloud page, but now it's vanished there. I just thought it might be due a permission problem.

I'm not sure what would cause it to appear on the tag cloud page. The first guess I had was that some tickets had TracJsGanttPlugin as a keyword, but a query yields no results.

comment:63 in reply to: ↑ 53 Changed 16 months ago by rjollos

Replying to rjollos:

I hadn't granted TAGS_VIEW. Sorry about that. You should see it now.

Note that I also granted TAGS_MODIFY at that time.

comment:64 in reply to: ↑ 38 Changed 16 months ago by rjollos

Replying to stoecker:

After login I get that everywhere.

AttributeError: 'TracHacksHtPasswdStore' object has no attribute 'user_email_verification_requested'

I think we've fixed this now in #11154, but please let me know if you find that's not the case.

comment:65 in reply to: ↑ 61 ; follow-up: Changed 16 months ago by hasienda

Replying to rjollos:

That might be a good modification to make to the NewHack template.

How does this look?

+1, looks great, provides intuitive links to resolved as well as open issues, and an overall impression on plugin status even before looking at a ticket listings.

Minor nit-pick: For some plugin's I'd like to have a miniature representation to be able to show a bundle of progress bars - on bar per ticket type. When there are 10 issues, it matters if 8 of them are bugs ore enhancement requests.

comment:66 in reply to: ↑ 65 ; follow-up: Changed 16 months ago by rjollos

Replying to hasienda:

Minor nit-pick: For some plugin's I'd like to have a miniature representation to be able to show a bundle of progress bars - on bar per ticket type. When there are 10 issues, it matters if 8 of them are bugs ore enhancement requests.

It might be possible to even show all the different ticket types in one bar (probably an enhancement to Trac is needed), similar to TracIni#milestone-groups-section, and have closed / defects / enhancements / tasks as colored segments of the bar and query links below the bar. That would provide all the information I need, because like you I care to see how many open defects vs enhancements vs tasks there are, but I don't really need to see the closed tickets categorized by ticket type.

Your edits to AccountManagerPlugin#BugsFeatureRequests look good though. The bars are only lacking a title, which is another possible enhancement to the TicketQuery macro, though we can probably just add it through wiki markup, or even WikiHtml if we want it to look really nice (e.g. adjust the font and font size) (see also #11045).

comment:67 in reply to: ↑ 66 Changed 16 months ago by hasienda

Replying to rjollos:

It might be possible to even show all the different ticket types in one bar (probably an enhancement to Trac is needed), similar to TracIni#milestone-groups-section, and have closed / defects / enhancements / tasks as colored segments of the bar and query links below the bar. That would provide all the information I need, because like you I care to see how many open defects vs enhancements vs tasks there are, but I don't really need to see the closed tickets categorized by ticket type.

Agreed, feeling the same. It will definitely need an enhancement to get ticket grouped by status and - at the same time - open tickets by type. Because there are so many possible use-cases, that having closes/defects/enhancements/tasks would be not enough. I know of some instances with more than 20 ticket types.

IMHO it would be valuable to just switch the criterion for grouping from ticket status to type and have two bars: an overall status + open ones grouped by type. An have a scaling attribute for miniature progress bar image, probably auto-popup-n-grow to 100% onMouseOver and go back to miniature when the pointer is dragged away from the image?

Last edited 16 months ago by hasienda (previous) (diff)

comment:68 Changed 16 months ago by falkb

Still something deep in my mind warns me the progress thingy is a bit odd here. For a while I was thinking why and I think I detected the reason now: It's the percent number. That makes it more look like you're aiming a certain date (on a roadmap), but it is not. What you want to display is just a coloured ticket type overview chart not chained to an aim. Maybe this is a bit captious but I bet some users will accociate it with the state until the next plugin version... probably it helps to mask out the percent value.

comment:69 in reply to: ↑ 38 Changed 16 months ago by rjollos

Replying to stoecker:

P.S. If I can help with the spamfilter, please ask.

I would like to take you up on this offer as much as possible. I'll contact you by email.

comment:70 Changed 16 months ago by rjollos

In 13283:

Refs #10193: Update links in ThemeEnginePluugin README for Trac 1.0 raw attachment link format.

comment:71 follow-up: Changed 16 months ago by falkb

Uhmm... I can't vote tickets and wiki anymore (?).

comment:72 in reply to: ↑ 71 Changed 16 months ago by rjollos

Replying to falkb:

Uhmm... I can't vote tickets and wiki anymore (?).

Removed to avoid an error that resulted in a traceback. Maybe one of the errors documented in #11149, but I don't remember. It will be reinstalled once we have sorted out what the problem is.

Installation of VotePlugin is being tracked in #8717.

Last edited 14 months ago by rjollos (previous) (diff)

comment:73 follow-up: Changed 16 months ago by anonymous

stoecker has pointed out that TracIniAdminPanelPlugin needs to be reinstalled because i18n translations aren't enabled.

comment:74 in reply to: ↑ 73 Changed 16 months ago by hasienda

Replying to anonymous:

stoecker has pointed out that TracIniAdminPanelPlugin needs to be reinstalled because i18n translations aren't enabled.

Right, but this is true for every plugin packaged in the virtual environment before we installed Babel. I noticed this for AcctMgr and TagsPlugin too, but no need to hurry from my point of view. It will come with next update automatically, and I hope to roll a lot of improvements in due time.

comment:75 Changed 15 months ago by hasienda

Been bitten by genshi:ticket:566 same way as mentioned in t:#11184 - another Genshi issue for the 0.7 release.

I wonder, if we should roll-back to 0.6 for a while, because I can't see much pushing to get Genshi issues fixed in a timely manner, and I cannot do it myself. Another option would be to maintain a version with published patches meanwhile, what might actually encourage fixing it upstream a bit more. Thoughts?

comment:76 follow-up: Changed 15 months ago by falkb

Realizing blog and news ticker at wiki start page is not sync'ed I wonder if it's a good idea to use

{{{
#!div class=blogflash
[[BlogList(recent=2, heading=News)]]
}}}

comment:77 in reply to: ↑ 76 Changed 15 months ago by hasienda

Replying to falkb:

Realizing blog and news ticker at wiki start page is not sync'ed

This is on purpose. We use tagging to mark blog posts for WikiStart, and I decided to not add the German developer meeting post, but announce it at out mailing-list instead.

comment:78 Changed 15 months ago by jun66j5

Hi, it seems NewHack page currently doesn't work. I have a new hack....

comment:79 Changed 15 months ago by rjollos

I've been feeling a bit guilty about not getting that working yet. The TracHacksPlugin seems to need a bit of work still. I'll take a look tomorrow and try to figure out what needs to be done still, and report back.

comment:80 Changed 14 months ago by rjollos

I've installed the ServerSideRedirectPlugin as a replacement for TracRedirect. The latter hadn't been reinstalled after the upgrade, so pages such as GoogleAnalyticsPlugin and AccountManager weren't redirecting.

Sorry the progress on the upgrade is moving so slow lately. I'll try to find time this week to finish up the major issues.

comment:81 Changed 14 months ago by rjollos

After this mailing list post, I searched for ?format=raw strings and made the following changes to each URL to fix the links:

  • removed ?format=raw
  • replaced attachment with raw-attachment

Please fix or let me know if you spot any I missed.

Last edited 14 months ago by rjollos (previous) (diff)

comment:82 Changed 14 months ago by calrsom

I also have a new hack, but the NewHack page doesn't work, presumably related to the NewHackMacro not being checked off in this ticket. I'm not in any hurry to upload, but thought I'd share a small LDAP Sync plugin I wrote to fill a gap between SSPI authentication and email notifications.

comment:83 Changed 14 months ago by rjollos

  • Description modified (diff)

Sorry for the continued delay on resurrecting the New Hack form. I will try to find some time to work on it this coming weekend.

If anyone is interested in contributing to that effort, the TracHacksPlugin provides the New Hack form now, and if I remember correctly there are some major issues that will quickly be discovered once you start testing. The NewHackMacro is deprecated.

comment:84 Changed 14 months ago by rjollos

Minor issue: The ListTagged macro is displaying No resources found. See wiki:experimentalut for an example. We probably want to suppress this on user pages.

comment:85 follow-up: Changed 13 months ago by falkb

Hi! I cannot attach files to TH tickets anymore. Look at #11289 where I reported the internal TH server error.

comment:86 in reply to: ↑ 85 Changed 13 months ago by falkb

Replying to falkb:

Hi! I cannot attach files to TH tickets anymore. Look at #11289 where I reported the internal TH server error.

yes, rjollos is right, changing the language to "English (US)" is a workaround (tracked at t:#11184, already)

comment:87 Changed 13 months ago by falkb

Hi! I noticed that CC adding uses my email address for the CC field but I don't want that, even not with a cut address string. falkb should be used. Please, could you make it that way again?

Last edited 13 months ago by falkb (previous) (diff)

comment:88 follow-up: Changed 13 months ago by mitar

Last edited 13 months ago by mitar (previous) (diff)

Changed 11 months ago by jun66j5

comment:89 follow-up: Changed 11 months ago by jun66j5

  • Cc jun66j5 added

I created patch, trachacksplugin-t10193-r13419.diff.

  • New Hack works well.
  • Shows the hint for focused input.
  • Clicking tag in cloud adds or removes the tag.
  • Uses /usr/bin/svn instead of /usr/bin/op command cause the command is missing in my environment.
  • Need to replace download:${LCNAME} with export:${LCNAME} in NewHackTemplate.

The patch needs more testing. Could somebody please try it?

comment:90 Changed 11 months ago by jun66j5

Any progress?

comment:91 Changed 11 months ago by rjollos

Sorry for the delay. I will try to make time to test it out by the weekend. Thanks for providing the patch!

comment:92 in reply to: ↑ 89 ; follow-up: Changed 10 months ago by rjollos

Replying to jun66j5:

I created patch, trachacksplugin-t10193-r13419.diff.

  • New Hack works well.
  • Shows the hint for focused input.
  • Clicking tag in cloud adds or removes the tag.
  • Uses /usr/bin/svn instead of /usr/bin/op command cause the command is missing in my environment.

It is working much better. I added a few more changes, and the latest can be found in t10193. There are a few things I noticed that I haven't fixed yet:

  • After filling out all the fields, the Create Hack button is still disabled, until the user does a Preview. Maybe this was intended, but it could be confusing, so we should probably at least have some sort of hint. Similarly, when the form doesn't submit due to failing a validation condition we should provide hints, but that can be done later.
  • Nothing is done with the Installation Instructions that are entered. They aren't inserted into the template.
  • Need to replace download:${LCNAME} with export:${LCNAME} in NewHackTemplate.

Done in this change.

Last edited 10 months ago by rjollos (previous) (diff)

comment:93 in reply to: ↑ 92 Changed 10 months ago by jun66j5

  • After filling out all the fields, the Create Hack button is still disabled, until the user does a Preview. Maybe this was intended, but it could be confusing, so we should probably at least have some sort of hint. Similarly, when the form doesn't submit due to failing a validation condition we should provide hints, but that can be done later.
  • Nothing is done with the Installation Instructions that are entered. They aren't inserted into the template.

I fixed these things and some issues, see https://github.com/jun66j5/trachacksplugin/commits/t10193.

comment:94 Changed 10 months ago by rjollos

Thanks. I'm testing it out and will try to get it installed by tomorrow if no other issues are found.

comment:95 Changed 10 months ago by rjollos

In 13483:

Fixes for New Hack form and display of tooltips. Patch by Jun Omae. Refs #10193.

  • Avoid error when no types are defined.
  • Normalize indentation in CSS file to 1 character.
  • The stylesheet wiki.css is needed for rendering the preview.
  • Open links to types and release in new tabs so that the user doesn't inadvertently navigate away from the page.
  • Don't hide hints even if browser's window is narrow.
  • Use box-sizing: border-box in order to be width: 100% for text fields in the form.
  • Added a mergin of between newhack form and footer.
  • Enable Create Hack button if all required inputs are filled.
  • Show hints when focusing input and entering container because don't show hints for checkbox and radio button.
  • Added --config-dir option for svn mkdir and retreives the configuration file from TRACHACKS_SVN_CONFIG_DIR environment
  • Prevent directory traversal attack using hack name, e.g. NewHack/../../../../../etc/passwd.
  • Added checks for existence of [trac] authz_file configuration option.
  • Fixed unbound variable umask.

comment:96 Changed 10 months ago by rjollos

I've installed the r13483 of the plugin and I'm testing it out. I'll make some comments in #11436 about the issue encountered.

comment:97 Changed 9 months ago by otaku42

In 13510:

Captured content from www/htdocs/site directory. Refs #10193.

comment:98 Changed 9 months ago by rjollos

With [13510], we should be able to restore the styling to the site. I'm hoping the site styling can be packaged with the TracHacksPlugin, since that would make it easier to maintain.

There is also a snippet in site.html that osimons added right after the 1.0 version of trac-hacks went live:

<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:py="http://genshi.edgewall.org/"
      py:strip="">

<!--! Add site-specific style sheet -->
<head py:match="head" py:attrs="select('@*')">
  ${select('*|comment()|text()')}
  <link rel="stylesheet" type="text/css"
        href="${href.chrome('site/style.css')}" />
</head>

<!--! Word of warning for creating new tickets -->
<form py:match="div[@id='content' and @class='ticket']/form[@id='propertyform']" py:attrs="select('@*')">
  <py:if test="req.environ['PATH_INFO'] == '/newticket' and (not 'preview' in req.args)">
    <div id="newticketguide">
      <h1>Stop!</h1>
      <hr />
      <p>Be sure to set the <strong>component</strong> of your ticket to the name of
         the hack you have a grievance with. Most hack pages will have a link
         specifically for creating new tickets against them. Use it.
      </p>
      <p>If you do not do this it is highly likely that the hack author <strong>will not be
        aware of your ticket and it will be ignored</strong>.</p>
      <hr />
      <p>Support and <a href="http://trac.edgewall.org/wiki/TracPlugins">installation</a> questions
         should be asked on the <a href="http://trac.edgewall.org/wiki/MailingList">mailing
         list</a> or <a href="http://trac.edgewall.org/wiki/IrcChannel">IRC channel</a>,
         not filed as tickets.
      </p>
    </div>
  </py:if>
  ${select('*')}
</form>

</html>

comment:99 Changed 8 months ago by rjollos

Pygments has been updated today from 1.3.1 to the latest (1.6), which fixes some minor issues I've noticed around the site.

comment:100 in reply to: ↑ 88 Changed 5 weeks ago by rjollos

Replying to mitar:

This plugin can be used for that.

Thanks. I'll look into whether that is suitable for integration to Trac.

comment:101 Changed 5 weeks ago by rjollos

  • Description modified (diff)

comment:102 Changed 5 weeks ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

#11949 has been created to tackle remaining issues with the upgrade. Please add anything I may have missed to that ticket. See also #11678.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.