id	summary	reporter	owner	description	type	status	priority	component	severity	resolution	keywords	cc	release
10219	[patch] bring searchattachments plugin to a working state	jholg	rjollos	SearchAttachmentsPlugin didn't quite work for me in several aspects so I applied some fixes to it. This has been a while and I always forgot to upload the corresponding patch, so here it is now.\r\n\r\nChanges that I made (excerpt from my mercurial local repo changelog):\r\n\r\n{{{\r\n$ hg log -v|egrep -v "user"\r\nchangeset:   8:e7c0cbbd158f                                            \r\ntag:         tip                                                       \r\ndate:        Thu Feb 18 17:02:32 2010 +0100                            \r\nfiles:       0.11/searchattachments/searchattachments.py               \r\ndescription:                                                           \r\nmore helpful log message if no index files found (means no attachments)\r\n\r\n\r\nchangeset:   7:cc617212dd70\r\ndate:        Thu Feb 18 16:30:19 2010 +0100\r\nfiles:       0.11/searchattachments/searchattachments.py\r\ndescription:                                            \r\nfixed unicode issue                                     \r\n\r\n\r\nchangeset:   6:d0afeb0b8a4b\r\ndate:        Thu Feb 11 11:25:20 2010 +0100\r\nfiles:       0.11/searchattachments/searchattachments.py\r\ndescription:                                            \r\nfixed options                                           \r\n\r\n\r\nchangeset:   5:bb5fdc6dc688\r\ndate:        Wed Feb 10 15:16:59 2010 +0100\r\nfiles:       0.11/searchattachments/searchattachments.py\r\ndescription:                                            \r\nMany changes, including reformatting and saner excerpt extraction, with\r\noptions to switch off excerpts and for limiting excerpt search and excerpt\r\nresult length.                                                            \r\n\r\n\r\nchangeset:   4:49a9ec1eb7a9\r\ndate:        Tue Feb 09 15:05:44 2010 +0100\r\nfiles:       0.11/searchattachments/searchattachments.py\r\ndescription:\r\nreformat for better style-guide conformity\r\n\r\n\r\nchangeset:   3:7ad1c267ebf4\r\ndate:        Wed Dec 30 15:32:39 2009 +0100\r\nfiles:       0.11/searchattachments/searchattachments.py 0.11/trac-seat\r\ndescription:\r\nFixed indentation using reindent.py, use spaces now instead of tabs.\r\ntrac-seat now indexes txt files, too. Force foreground job for attachment\r\ndeletions to not get inconsistent indexing in case of 'replace attachm.\r\nwith the same name' operations. Excerpt handling now works for files that\r\ndo not contain any newlines before a search keyword.\r\n\r\n\r\nchangeset:   2:bd327f343d0c\r\ndate:        Mon Dec 28 14:39:05 2009 +0100\r\nfiles:       0.11/trac-seat\r\ndescription:\r\nremoved obsolete commented-out stuff\r\n\r\n\r\nchangeset:   1:4540952d9e13\r\ndate:        Wed Dec 23 17:07:23 2009 +0100\r\nfiles:       0.11/searchattachments/searchattachments.py 0.11/setup.py 0.11/trac-seat\r\ndescription:\r\n1st working version. Changes:\r\n * trac-seat added as script to setup.py\r\n * trac-seat fixed: Option parsing now working, use trac Configuration class\r\n   for ini file access (otherwise, inherit mechanisms will not work), some\r\n   fixes regarding reading the relevant config sections\r\n * change config section name to use 'searchattachments' consistently\r\n * fixed seat and swish options\r\n * use absolute urls in results to support multi-project (tracforge) setups;\r\n   absolute urls are constructed from the request href\r\n\r\n\r\nchangeset:   0:2b345fa0a9a3\r\ndate:        Wed Dec 23 14:19:46 2009 +0100\r\nfiles:       0.10/README 0.10/searchattachments/__init__.py \r\n0.10/searchattachments/searchattachments.py \r\n0.10/setup.py \r\n0.10/trac-seat \r\n0.11/README 0.11/searchattachments/__init__.py \r\n0.11/searchattachments/searchattachments.py \r\n0.11/setup.py 0.11/trac-seat\r\ndescription:\r\ninitial checkin\r\n\r\n}}}\r\n\r\nI've been running this ever since in a production trac environment and it works quite nicely.\r\n\r\n	defect	new	normal	SearchAttachmentsPlugin	normal				0.11