id	summary	reporter	owner	description	type	status	priority	component	severity	resolution	keywords	cc	release
10226	Uses wrongly `re.match` for `[bookmark] paths` settings	jun66j5	saigon	It seems `[bookmark] paths` supports shell wildcards, not regular expression.\r\n{{{\r\n#!py\r\n    bookmarkable_paths = ListOption('bookmark', 'paths', '/*',\r\n        doc='List of URL paths to allow bookmarking on. Globs are supported.')\r\n}}}\r\n\r\nBut the plugin uses `re.match` for each value with no changes.\r\n{{{\r\n#!py\r\n    def post_process_request(self, req, template, data, content_type):\r\n        # Show bookmarks context menu except when on the bookmark page\r\n        if 'BOOKMARK_VIEW' in req.perm and not self.match_request(req):\r\n            for path in self.bookmarkable_paths:\r\n                if re.match(path, req.path_info):\r\n                    self.render_bookmarker(req)\r\n                    break\r\n        return template, data, content_type\r\n}}}\r\n\r\nI think it should fix to be able to use shell wildcards.	defect	closed	normal	BookmarkPlugin	normal	fixed		jun66j5, rjollos, hasienda	0.12