Ticket #1035 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Internal error when trying to create a new code review

Reported by: anonymous Assigned to: Team5
Priority: normal Component: PeerReviewPlugin
Severity: critical Keywords: Clearsilver Tag Parse Error
Cc: Trac Release: 0.10

Description

Following the nav link to create a new code review results in "Trac detected an internal error".

Traceback: 

Traceback (most recent call last):
  File "C:\Python\Lib\site-packages\trac\web\main.py", line 387, in dispatch_request
    dispatcher.dispatch(req)
  File "C:\Python\Lib\site-packages\trac\web\main.py", line 244, in dispatch
    req.display(template, content_type or 'text/html')
  File "C:\Python\Lib\site-packages\trac\web\api.py", line 358, in display
    data = self.hdf.render(template, form_token)
  File "C:\Python\Lib\site-packages\trac\web\clearsilver.py", line 296, in render
    injector.feed(template.render())
  File "C:\Python\Lib\HTMLParser.py", line 108, in feed
    self.goahead(0)
  File "C:\Python\Lib\HTMLParser.py", line 148, in goahead
    k = self.parse_starttag(i)
  File "C:\Python\Lib\HTMLParser.py", line 226, in parse_starttag
    endpos = self.check_for_whole_start_tag(i)
  File "C:\Python\Lib\HTMLParser.py", line 301, in check_for_whole_start_tag
    self.error("malformed start tag")
  File "C:\Python\Lib\HTMLParser.py", line 115, in error
    raise HTMLParseError(message, self.getpos())
HTMLParseError: malformed start tag, at line 269, column 36

Trac version: 0.10.3

Attachments

trac.patch (0.9 kB) - added by akhavr@gmail.com on 02/20/07 17:04:59.
Trac patch that hides the problem

Change History

01/04/07 05:37:47 changed by rob.sharp@thesoundalliance.net

I'm also seeing this on trac 0.10.3 on rhel4 with python 2.3

01/06/07 00:31:17 changed by anonymous

  • keywords set to Clearsilver Tag Parse Error.
  • severity changed from normal to major.

Same here on OpenSuSE 10.2 . I think I remember reading that there's a patch for clearsilver to fix this... I'll look around ... and report back

02/01/07 17:26:30 changed by DPadbury@rhetorik.com

Reproduced on Trac 0.10.3 on Windows 2003 with Python 2.4.

02/02/07 09:45:34 changed by anonymous

  • severity changed from major to critical.

02/03/07 09:16:02 changed by eric@imitix.com

Also a bug on FreeBSD w/ Python 2.4, Trac 0.10.3.

02/07/07 06:25:14 changed by akhavr@gmail.com

Confirmed on trac-0.10.3 and python 2.4. Any progress/updates here?

02/20/07 17:04:59 changed by akhavr@gmail.com

  • attachment trac.patch added.

Trac patch that hides the problem

02/20/07 17:06:38 changed by akhavr@gmail.com

Attached patch to trac hides the problem by surrounding the verification by try-except pair.

02/21/07 00:33:49 changed by rob.sharp@thesoundalliance.net

Thanks for that patch akhavr, but it looks like the source of the issue is now apparent:

"No handler matched request to /peerReviewBrowser"

Am i missing something?

02/21/07 06:30:01 changed by akhavr@gmail.com

No, Rob, I don't get such error. As I mentioned here, after this ticket issue is hidden by the patch above, the #938 pops up, which requires much more deep experience with the plugin.

Linux, apache 2.0.55, mod_python 3.1.4, trac 0.10.3, python 2.4.2

05/30/07 13:54:01 changed by mikechml

  • status changed from new to closed.
  • resolution set to fixed.

(In [2270]) fixes #938, #1035 refs #650

Moved large portions of javascript to external files to avoid parser errors, and keep it tidy. Fixes for preview_to_hdf. Should now work with 0.10

Add/Change #1035 (Internal error when trying to create a new code review)




Change Properties
Action