Modify

Opened 2 years ago

Last modified 7 months ago

#10482 new enhancement

Extend `ignore_cc_changes` option to other fields

Reported by: rjollos Owned by: doki_pen
Priority: normal Component: AnnouncerPlugin
Severity: normal Keywords:
Cc: hasienda, jared.bownds@… Trac Release: 0.12

Description

The ignore_cc_changes option, when set to true, skips notification when the only change is to the CC list. This could be extended to other fields, with the option to ignore all fields.

[Announcer]
ignore_field_changes = cc, keywords, severity
[Announcer]
ignore_field_changes = all

This would satisfy t:#2200.

Attachments (0)

Change History (5)

comment:1 follow-up: Changed 2 years ago by psuter

Wouldn't it be more in the spirit of Announcer to allow users to select which field changes they are not interested in?

This could be done with IAnnouncementSubscriber that provides a subscription for never notify me when a ticket change only includes boring fields. In a preferences panel each ticket field would need a checkbox to indicate if the user considers it boring. The ignore_cc_changes could even be moved to a IAnnouncementDefaultSubscriber for that rule, so users can override it in case they actually are interested in cc changes.

comment:2 in reply to: ↑ 1 Changed 2 years ago by rjollos

  • Cc hasienda added

Replying to psuter:

Wouldn't it be more in the spirit of Announcer to allow users to select which field changes they are not interested in?

Yes, I agree, if the administrator grants the users ability to make these changes.

This could be done with IAnnouncementSubscriber that provides a subscription for never notify me when a ticket change only includes boring fields. In a preferences panel each ticket field would need a checkbox to indicate if the user considers it boring. The ignore_cc_changes could even be moved to a IAnnouncementDefaultSubscriber for that rule, so users can override it in case they actually are interested in cc changes.

The features you suggest and the feature I suggested don't seem mutually exclusive. What do you think of the following as goals for this ticket?:

  • Provide a default ignore setting for each field.
  • Provide a user ignore preference for each field.
  • Provide administrator control over whether the user can set ignore preferences.

comment:3 follow-up: Changed 2 years ago by psuter

Yes, I see what you mean. Sorry for derailing your ticket. It just surprised me that AnnouncerPlugin has admin-only options to skip notifications. Wasn't getting rid of that kind of thing (one of) the reason(s) it exists in the first place?

comment:4 in reply to: ↑ 3 Changed 2 years ago by rjollos

Replying to psuter:

Yes, I see what you mean. Sorry for derailing your ticket. It just surprised me that AnnouncerPlugin has admin-only options to skip notifications.

I might eventually open a different ticket for the work you suggested, but it seem important to consider those feature in the context of this ticket. I haven't studied the extension points in much detail, so anything you add to the discussion such as your suggestion to add an IAnnouncementDefaultSubscriber interface, is valuable in my opinion.

Wasn't getting rid of that kind of thing (one of) the reason(s) it exists in the first place?

I'm not sure of the history of the plugin, but it does seem like one of the motivations is to give users more control through the preferences panel. I favor this approach, in combination with administrator control over which preference panels a user can access.

comment:5 Changed 7 months ago by rjollos

  • Cc jared.bownds@… added

#11680 closed as a duplicate.

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.