Ticket #10487 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

Plugin doesn't load using setuptools develop command

Reported by: rjollos Assigned to: olemis
Priority: normal Component: PyTppThemePlugin
Severity: normal Keywords: setuptools develop
Cc: Trac Release: 0.12

Description

I see this error when starting Trac: 

02:28:19 PM Trac[loader] ERROR: Skipping "pytpptheme.theme = pytpptheme.theme": (can't import "ImportError: No module named pytpptheme.theme")

One way to fix the issue is to just rename the pytppthemeplugin/0.11/pydotorgtheme@7223 to pytppthemeplugin/0.11/pytpptheme. Alternatively, the attached patch can be used.

Attachments

th10487.patch (447 bytes) - added by rjollos on 10/15/12 23:35:43.
Patch against r7223 of the plugin.

Change History

10/15/12 23:35:43 changed by rjollos

  • attachment th10487.patch added.

Patch against r7223 of the plugin.

10/15/12 23:41:13 changed by rjollos

I don't think the attached patch is the correct way to fix this, because it appears that the directory was just misnamed. So probably just a directory rename is all that is needed to fix the issue.

10/22/12 21:23:44 changed by rjollos

  • status changed from new to closed.
  • resolution set to fixed.

(In [12240]) Fixes #10487: Fixed misnamed directory.

10/22/12 21:49:22 changed by olemis

  • keywords set to setuptools develop.
  • summary changed from Plugin doesn't load to Plugin doesn't load using setuptools develop command.

I appreciate your feedback . Initially I was thinking of reverting them because since the beginning I had in mind not to change that folder name . Notice that even if your changes make it work from fresh svn checkout + setuptools develop command (that's why /me not reverting [12240] ) , in the end it will break distutils sdist and bdist* commands . Hence I've committed [12242] .

In the future it'd be nice if you please could mention proposed changes in the form of a patch and wait for me to review and give green light before committing changes .

10/22/12 21:58:05 changed by olemis

or better ...are you ok with creating a patch queue at bitbucket so that you (and others) can hack the code and submit patches in an organized manner ?

wiki:olemis#Guidelinestocollaborate

Add/Change #10487 (Plugin doesn't load using setuptools develop command)




Change Properties
Action