Modify

Opened 22 months ago

Closed 20 months ago

Last modified 20 months ago

#10611 closed defect (wontfix)

The parent ticket is not an active ticket (status: closed).

Reported by: l0co@… Owned by: walnut
Priority: normal Component: ChildTicketsPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

This is an error displayed when you want to change anything in the child ticket when parent ticket is closed.

This restriction in nonsense and harmful. It prevents from even adding comments to child tickets, when the parent ticket is closed (why????). This is normal trac behaviour to add comments to closed ticket (with some remarks, doing reopen etc). It makes this plugin unusable.

This feature should be removed as unnecessary.

Attachments (0)

Change History (4)

comment:1 Changed 21 months ago by l0co@…

Beacuse no any activity here, I did it myself. Here is the solution, edit the file childtickets/childtickets.py and comment there lines:

# If the parent is 'closed' then we should not be allowed to create a new child ticket against that parent.
#if parent['status'] == 'closed':
#    yield 'parent', "The parent ticket (#%s) is not an active ticket (status: %s)." % (pid,parent['status'])

Rebuild, reinstall ... and now, the plugin is usable.

comment:2 Changed 20 months ago by walnut

  • Resolution set to wontfix
  • Status changed from new to closed

Hi

The idea here was to prevent child tickets being created against parents that are already closed.

In the development environments I have worked in, we've generally had a rule that tickets should only be worked on in an 'open' state. That would mean re-opening the ticket first (and the parent if that is also closed!). Because this restriction is being tested for in the ITicketManipulator::validate_ticket function, there's no easy way to distinguish between creating a new ticket, simply adding a comment to an already closed ticket or performing some other change to the child ticket ...

I'm glad you got it working and adapted to your environment easily. Perhaps there should be an option here to allow child tickets to be created/modified against closed parent tickets?

Regards
Mark

comment:3 Changed 20 months ago by l0co@…

Yes. It would be fair enough to have the option to disable this feature. I understand your motivation and it looks fine for me, the only problem is that this restriction influences every change you'd like to perform on child ticket, when the parent ticket is closed (like adding a comment), so (probably because of the trac architecture, as you said) is far too much restrictive.

On the other hand your plugin is really helpful and simple, and I use it on daily basis. Thanks!

comment:4 Changed 20 months ago by l0co@…

BTW. I use for example different workflow, where I don't need the feature above.

I have bigger Feature ticket that can have Task, Bug, Idea subtickets.

So while the Feature is open, usually it has some Tasks attached. When all Tasks are done, the Feature is done. But this shouldn't prevent to still add the Bugs and Ideas below the Feature, and what shouldn't always reopen Feature (it's still done).

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.