Opened 11 years ago

Last modified 13 months ago

#10625 closed defect

AssertionError in trac.db.pool.PooledConnection.__del__ — at Version 4

Reported by: anonymous Owned by: Steffen Hoffmann
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: database API
Cc: Trac Release: 1.0

Description (last modified by Steffen Hoffmann)

On login and logout I get the following error (for each environment):

Exception exceptions.AssertionError: <exceptions.AssertionError instance at 0x89faeacc> in <bound method PooledConnection.__del__ of <trac.db.pool.PooledConnection object at 0xb47cc88c>> ignored

It is related with the single sign on feature. It can be easily fixed by explicitly closing the database connection with db.close after the commit in the following lines:

Change History (4)

comment:1 Changed 11 years ago by ms4py

Well, a cleaner fix would be to upgrade the database access in general.

comment:2 Changed 11 years ago by ms4py

Cc: ms4py added; anonymous removed

comment:3 Changed 11 years ago by ms4py

I have upgraded the plugin to use the Trac 1.0 database API. Let me know if you are interested in the patch.

comment:4 in reply to:  description Changed 11 years ago by Steffen Hoffmann

Description: modified (diff)
Keywords: database API added

Replying to anonymous:

On login and logout I get the following error (for each environment):

Exception exceptions.AssertionError: ...

It is related with the single sign on feature. It can be easily fixed by explicitly closing the database connection with db.close after the commit in the following lines:

I strongly disagree, and this is backed by developer discussion. A forced close may yield other side-effects, and current Trac db API strongly advocates for not using such forceful actions to a transaction in general.

Note: See TracTickets for help on using tickets.