Ticket #10678 (closed defect: fixed)

Opened 6 months ago

Last modified 5 months ago

Errors in source verification for 0.4 release

Reported by: rjollos Assigned to: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: normal Keywords: packaging
Cc: Trac Release:

Description

This appears to be related to [12399]: 

[ryano-admin@...]$ sudo python ./contrib/signatures.py
md5: "contrib/contrib/sessionstore_convert.py" missing
md5: "contrib/contrib/signatures.py" missing
md5: "contrib/contrib/style.css" missing
sha1: "contrib/contrib/sessionstore_convert.py" missing
sha1: "contrib/contrib/signatures.py" missing
sha1: "contrib/contrib/style.css" missing
sha1: "acct_mgr-sha1sums.sig" unknown (added)
md5: "acct_mgr-sha1sums.sig" unknown (added)
sha1: "acct_mgr-md5sums.sig" unknown (added)
md5: "acct_mgr-md5sums.sig" unknown (added)

I don't know enough about hash generation and verification to know exactly how to fix this, but if I delete the entries with a leading path of contrib/contrib, then I get: 

[ryano-admin@...]$ sudo python ./contrib/signatures.py
sha1: "acct_mgr-sha1sums.sig" unknown (added)
md5: "acct_mgr-sha1sums.sig" unknown (added)
sha1: "acct_mgr-md5sums.sig" unknown (added)
md5: "acct_mgr-md5sums.sig" unknown (added)
Check passed.

  • acct_mgr-md5sums

    old new  
    1414e73ff08eb165e3e316f9a9087a050ff8 acct_mgr/templates/account_details.html 
    1515579ba581f37a51b07e6c73eb7910537f acct_mgr/http.py 
    16161ef2d05ca97716b0d1b2cc520f1ea6dc acct_mgr/locale/sv/LC_MESSAGES/acct_mgr.po 
    17 7c15faa40a56b626d3800d5eb499fea3 contrib/contrib/sessionstore_convert.py 
    181762ac60600ca08175f64450aaf28717cc acct_mgr/locale/et/LC_MESSAGES/acct_mgr.po 
    19 92f35922aa6e3e5f1d4c632ed2379620 contrib/contrib/signatures.py 
    2018f75e73cf85af94a2d290217002f24cbe acct_mgr/guard.py 
    21195e3aaebeb37a3f5ccf2936d9b0220d8a acct_mgr/locale/te/LC_MESSAGES/acct_mgr.po 
    2220c2dc4a888edb9245452464358fb58696 acct_mgr/locale/id_ID/LC_MESSAGES/acct_mgr.po 
    …… 
    3230ba86b97ac7b4e5d5d820ce795806a543 acct_mgr/locale/zh_CN/LC_MESSAGES/acct_mgr.po 
    3331e7bdb13c2101e46ce5267225171f7ac5 setup.py 
    34327c15faa40a56b626d3800d5eb499fea3 contrib/sessionstore_convert.py 
    35 80d33a38a41a4c55dd6c1bdfcba0139f contrib/contrib/style.css 
    36332eb19a946c81096e427f8985d8e9b449 acct_mgr/locale/it/LC_MESSAGES/acct_mgr.po 
    37347be32664b8f9016041c29d11e483ae64 acct_mgr/templates/prefs_account.html 
    383580d33a38a41a4c55dd6c1bdfcba0139f contrib/style.css 

  • acct_mgr-sha1sums

    old new  
    14148731757c4dceafce0971f2472ef7696c91e17db6 acct_mgr/templates/account_details.html 
    151582a7cccd7313f4c9acbfe375347552a3dbb60463 acct_mgr/http.py 
    1616dda4380b9195a68ad13463bddf7c1e0a2e8c158f acct_mgr/locale/sv/LC_MESSAGES/acct_mgr.po 
    17 264d930c5893f6d8d04d14b797a570ecbda1ccd9 contrib/contrib/sessionstore_convert.py 
    1817f14c34993658aa8ea7cf81a553972fe336ed0db8 acct_mgr/locale/et/LC_MESSAGES/acct_mgr.po 
    19 3e341c9caa8568be919716606c490f262aa0b591 contrib/contrib/signatures.py 
    20188d02462b00ff89b2f783ba9c384666cb670e69ac acct_mgr/guard.py 
    2119381f8192f665863a5a5f4305d808f4b0c2a3ebef acct_mgr/locale/te/LC_MESSAGES/acct_mgr.po 
    2220daededb8cb96a042a4a7d3dd4c8b426540705d8a acct_mgr/locale/id_ID/LC_MESSAGES/acct_mgr.po 
    …… 
    32306c439fce7e9b048994b4ee905d95d106fca66ed0 acct_mgr/locale/zh_CN/LC_MESSAGES/acct_mgr.po 
    33316a53fda554fcc9b82b742c050053e75da4bd5dad setup.py 
    3432264d930c5893f6d8d04d14b797a570ecbda1ccd9 contrib/sessionstore_convert.py 
    35 57a21d4e1a5675859968ab20de64c91f0aaa8b88 contrib/contrib/style.css 
    36337b1b37e1bc047dfea261fdad2300aa59b8db6785 acct_mgr/locale/it/LC_MESSAGES/acct_mgr.po 
    3734959be704a76dfc6ff8780cca79d9cbb797871d58 acct_mgr/templates/prefs_account.html 
    383557a21d4e1a5675859968ab20de64c91f0aaa8b88 contrib/style.css 

Attachments

Change History

(in reply to: ↑ description ) 12/05/12 23:26:05 changed by hasienda

  • keywords set to packaging.

Replying to rjollos:

This appears to be related to [12399]: ...

Very good, thanks for noticing. It has slipped through.

I don't know enough about hash generation and verification to know exactly how to fix this, but if I delete the entries with a leading path of contrib/contrib, then I get: 

[ryano-admin@...]$ sudo python ./contrib/signatures.py
sha1: "acct_mgr-sha1sums.sig" unknown (added)
md5: "acct_mgr-sha1sums.sig" unknown (added)
sha1: "acct_mgr-md5sums.sig" unknown (added)
md5: "acct_mgr-md5sums.sig" unknown (added)
Check passed.

That's expected. The OpenPGP signatures can't be included in checksum files, because they're created after their creation. It's a recursion issue, that can't be solved another way, because you'll never know the correct hash for the signature file before actually signing the checksum file.

12/05/12 23:43:40 changed by hasienda

  • status changed from new to closed.
  • resolution set to fixed.

(In [12406]) AccountManagerPlugin: Complementary clean-up for [12399], closes #10678.

Updating contrib\signature.py in trunk to release version as well.

Add/Change #10678 (Errors in source verification for 0.4 release)




Change Properties
Action