Provide feedback when performing actions on the Users page

[rjollos]

Provide feedback on the Users admin panel by calling add_notice when creating users, changing users, resetting passwords and deleting accounts.

[rjollos]

I'm running r12589 at the moment and grabbed this screen capture while adding some users yesterday:

At first I was just going to say that we should add some space between the div with the message and the Add/Edit Acccount fieldset. However, thinking about it some more, maybe it would be better to use add_notice here, and display the message in the standard location. What do you think?

There is another major issue here that I need to investigate some more and open a ticket for. Notice that there are no accounts in the table in the screen capture. What I'm observing is that the table is empty when the page reloads after adding or editing a user. However, after a page refresh all of the users re-appear in the table.

[hasienda]

Replying to rjollos:

I'm running r12589 at the moment ...

There is another major issue here that I need to investigate some more and open a ticket for. Notice that there are no accounts in the table in the screen capture. What I'm observing is that the table is empty when the page reloads after adding or editing a user. However, after a page refresh all of the users re-appear in the table.

Oh, I can reproduce indeed. Thanks for the notification. I'll investigate and hopefully fix it right-away, keeping further comments here to track that issue down.

[hasienda]

(In [12606]) AccountManagerPlugin: Fix filter field names in user admin panel, refs #9946, #10682 and #10684.

This was flawed since the start with [12515] and I still didn't recognize the
duplicate 'email' field in both, account property editor and new filter form
when fixing their illegal nesting in [12539].

Thanks to Ryan J Ollos for notification to make me go and finally find it.

[hasienda]

(In [12660]) AccountManagerPlugin: Complete filter fix for user admin panel, refs #9946, #10682 and #10684.

While removing the name clash in [12606], the same changes actually broke
saving of filter values completely.

Thanks to slav0nic for confirmation of that unexpected discovery.

[hasienda]

(In [12661]) AccountManagerPlugin: Provide more feedback on actions in admin panels, refs #10684.

Unify message presentation to Trac core message area (top of page).