Ticket #10687 (closed defect: fixed)

Opened 5 months ago

Last modified 3 months ago

Can't drag item into last table row

Reported by: rjollos Assigned to: rjollos
Priority: normal Component: AdminEnumListPlugin
Severity: normal Keywords:
Cc: jun66j5, nonplus Trac Release:

Description

It is not currently possible to drag an item into the last row. I found one hint that suggested this is because the last element is flush against the bottom of the container, and the solution is to add some padding.

Attachments

t10687-r12416-mousemove.diff (1.6 kB) - added by jun66j5 on 12/08/12 13:58:26.
including fix of #10664

Change History

12/08/12 13:58:26 changed by jun66j5

  • attachment t10687-r12416-mousemove.diff added.

including fix of #10664

12/08/12 13:58:39 changed by jun66j5

I just found the same ;)

This issue is caused by the broken capture of mouse position. The following code does not work. 

	$().mousemove(function(e) {
		mouseY = e.pageY;
	});

Also, it causes the another issue. After clicking checkbox or radio buttons, it cannot drag the items.

After t10687-r12416-mousemove.diff, it would be possible to drag into the last row.

12/08/12 20:13:17 changed by rjollos

Thanks! I will commit the change by later this evening. If you have a chance to look at any of the other changes and have any comments, I appreciate any feedback you have.

(follow-up: ↓ 5 ) 12/09/12 12:57:07 changed by rjollos

  • status changed from new to assigned.

I have to wonder though, why the original author didn't just use jQuery UI's sortable widget, which should handle a lot of this work behind the scenes. The API docs say it has been available since jQuery UI 1.0.

The BacklogPlugin utilizes the sortable widget, and the code is much more concise.

12/09/12 14:44:16 changed by rjollos

This ticket is next up on my list, but I'll have to wait until morning. Thanks for all of your testing!

(in reply to: ↑ 3 ) 12/10/12 11:29:38 changed by jun66j5

Replying to rjollos:

I have to wonder though, why the original author didn't just use jQuery UI's sortable widget, which should handle a lot of this work behind the scenes. The API docs say it has been available since jQuery UI 1.0.

+1, good idea and useful information. I didn't think that sortable works with table elements.

12/21/12 18:05:57 changed by rjollos

(In [12460]) Refs #10687:

  • FIX: It was not possible to drag an item into the last row.
  • FIX: drag of items was broken after selecting a checkbox, radio button or select.

Patch by Jun Omae (jun66j5).

(follow-up: ↓ 8 ) 12/21/12 18:08:58 changed by rjollos

I previously ran into trouble getting the sortable widget working with Trac 0.11 while working on the BacklogPlugin. I'm not certain, but I suspect that the sortable widget won't work with the versions of jQuery in Trac 0.11.x (see comment:5:ticket:10657).

(in reply to: ↑ 7 ) 12/27/12 18:33:40 changed by anonymous

Replying to rjollos:

I previously ran into trouble getting the sortable widget working with Trac 0.11 while working on the BacklogPlugin.

I see now that I had some luck getting jQuery UI 1.6 working with Trac 0.11.1 and later in #10331, so I've created ticket #10732 for using the Sortable widget in this plugin. I guess this is a good step to make prior to t:#10994.

02/17/13 03:52:29 changed by rjollos

  • status changed from assigned to closed.
  • resolution set to fixed.

Add/Change #10687 (Can't drag item into last table row)




Change Properties
Action