Modify

Opened 16 months ago

Closed 4 months ago

Last modified 4 months ago

#10729 closed defect (fixed)

Templates have hard-coded paths to stylesheets.

Reported by: rjollos Owned by: rjollos
Priority: normal Component: PeerReviewPlugin
Severity: trivial Keywords: chrome web_ui genshi templates
Cc: olemis, yudivian, dm@… Trac Release:

Description

For example, peerReviewBrowser.html contains:

<link rel="stylesheet" href="/trac-mysql/chrome/common/css/code.css" type="text/css" media="screen, projector, print" />
<link rel="stylesheet" href="/trac-mysql/chrome/common/css/browser.css" type="text/css" media="screen, projector, print" />

Attachments (0)

Change History (9)

comment:1 Changed 16 months ago by rjollos

  • Status changed from new to assigned
  • Summary changed from Templates have hard-coded references to stylesheets. to Templates have hard-coded paths to stylesheets.

comment:2 Changed 16 months ago by rjollos

  • Cc extorue added

The templates that should have these hard-coded link elements removed from head are: peerReviewBrowser.html, peerReviewCommentCallback.html, peerReviewMain.html, peerReviewOptions.html, peerReviewSearch.html and peerReviewView.html. If those stylesheets are needed in those templates, they should be added using a call to add_stylesheet. I haven't looked as to whether that is already done, and whether the stylesheets are being added everywhere they are needed.

If someone else would like to pickup this ticket and resolved the issue, feel free to do so.

comment:3 Changed 16 months ago by olemis

  • Cc rjollos added
  • Keywords chrome web_ui genshi templates added
  • Owner changed from rjollos to extorue
  • Severity changed from normal to trivial
  • Status changed from assigned to new

Thanks rjollos . I think this is a very good starting point for our work . Considering your previous I'll be assigning this ticket to extorue . Do not hesitate to change anything is there's a good reason for doing so .

comment:4 Changed 16 months ago by rjollos

#10731 and #10782 may be good starting points for getting familiar with the codebase as well, and I wouldn't mind at all if someone beat me to implementing those ;)

comment:5 Changed 14 months ago by olemis

  • Owner changed from extorue to yudivian

comment:6 Changed 14 months ago by olemis

  • Cc yudivian added; extorue removed

comment:7 Changed 4 months ago by rjollos

  • Cc dm@… added; rjollos removed
  • Owner changed from yudivian to rjollos
  • Status changed from new to assigned

comment:8 Changed 4 months ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13502:

Add stylesheets using add_stylesheet. Fixes #10729.

This fixes some incorrect hard-coded paths in link elements in the templates.

comment:9 Changed 4 months ago by rjollos

[13502#file0] is an unintended change, but I'm not going to worry about it since it's generally harmless and the branch won't be maintained.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.