Opened 6 years ago
Closed 6 years ago
#1076 closed defect (fixed)
Input charset used for htmldoc should not be trac default
| Reported by: | tonin | Owned by: | tonin |
|---|---|---|---|
| Priority: | high | Component: | PageToPdfPlugin |
| Severity: | normal | Keywords: | charset |
| Cc: | Trac Release: | 0.10 |
Description
As we know, htmldoc isn't utf-8 compatible. However, quite a lot of Trac site these days are using utf-8 as default_charset. This parameter is needed so that utf-8 encoded comments in subversion are rendered correctly under the source browser.
So using this same default_charset as encoding for input feeded to htmldoc is problematic. We'd better use the output charset for this purpose.
See attached patch as proposed solution. I also added a html meta tag containing this charset so that eventually newer version of htmldoc will correctly use it.
Attachments (1)
Change History (9)
Changed 6 years ago by tonin
comment:1 Changed 6 years ago by anonymous
- Cc antoine@… added
comment:2 Changed 6 years ago by durchanek@…
- Priority changed from normal to high
comment:3 Changed 6 years ago by tonin
- Cc antoine@… removed
Alec, if you gave me SVN write access on this directory, I'd be gald to help and commit my changes.
comment:5 Changed 6 years ago by tonin
- Status changed from new to assigned
comment:6 Changed 6 years ago by tonin
- Resolution set to fixed
- Status changed from assigned to closed
comment:7 Changed 6 years ago by anonymous
- Resolution fixed deleted
- Status changed from closed to reopened
There's still a problem in case the page from which we generate the PDF contains characters that cannot be represented in the desired output charset. For info, the supported HTMLDOC charsets currently are http://www.htmldoc.org/htmldoc.html#9_2_12
comment:8 Changed 6 years ago by tonin
- Resolution set to fixed
- Status changed from reopened to closed
I can confirm that this patch is working correctly and I think it should be added to the main tree.