Ticket #1076 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Input charset used for htmldoc should not be trac default

Reported by: tonin Assigned to: tonin
Priority: high Component: PageToPdfPlugin
Severity: normal Keywords: charset
Cc: Trac Release: 0.10

Description

As we know, htmldoc isn't utf-8 compatible. However, quite a lot of Trac site these days are using utf-8 as default_charset. This parameter is needed so that utf-8 encoded comments in subversion are rendered correctly under the source browser.

So using this same default_charset as encoding for input feeded to htmldoc is problematic. We'd better use the output charset for this purpose.

See attached patch as proposed solution. I also added a html meta tag containing this charset so that eventually newer version of htmldoc will correctly use it.

Attachments

pagetopdf.py.diff (1.7 kB) - added by tonin on 01/05/07 18:39:14.

Change History

01/05/07 18:39:14 changed by tonin

  • attachment pagetopdf.py.diff added.

01/08/07 14:45:57 changed by anonymous

  • cc set to antoine@delvaux.net.

02/16/07 20:04:45 changed by durchanek@gmail.com

  • priority changed from normal to high.

I can confirm that this patch is working correctly and I think it should be added to the main tree.

02/19/07 14:52:03 changed by tonin

  • cc deleted.

Alec, if you gave me SVN write access on this directory, I'd be gald to help and commit my changes.

02/19/07 15:08:43 changed by athomas

  • owner changed from athomas to tonin.

Good idea, fire away.

02/27/07 19:14:59 changed by tonin

  • status changed from new to assigned.

02/27/07 19:16:12 changed by tonin

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [2050]) Fix #1076 better default_charset.

03/12/07 14:05:02 changed by anonymous

  • status changed from closed to reopened.
  • resolution deleted.

There's still a problem in case the page from which we generate the PDF contains characters that cannot be represented in the desired output charset. For info, the supported HTMLDOC charsets currently are http://www.htmldoc.org/htmldoc.html#9_2_12

03/12/07 14:09:59 changed by tonin

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [2100]) Replacing characters without equivalent in the desired output charset (fix #1076).

Add/Change #1076 (Input charset used for htmldoc should not be trac default)




Change Properties
Action