Modify

Opened 19 months ago

Closed 14 months ago

Last modified 14 months ago

#10797 closed defect (fixed)

Update to xhtml2pdf from pisa (as pisa is now obsolete)

Reported by: charlie@… Owned by: rjollos
Priority: normal Component: TracWikiPrintPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description (last modified by rjollos)

Following chages are necessary :

  1. Two files needs to be changed :
    wikiprint.py
    web_ui.py
    
  • replace import ho.pisa as pisa with import xhtml2pdf.pisa as pisa
  1. Installer needs to be changed (not done yet)

If someone will create a new version, please do not omit this. Maybe I will do it in the future as there are other 3 enhancements already done and not published yet.

Attachments (0)

Change History (7)

comment:1 Changed 16 months ago by rjollos

  • Description modified (diff)

comment:2 Changed 16 months ago by rjollos

  • Owner changed from airadier to rjollos
  • Status changed from new to assigned

Thanks, I will take a look and likely push the change.

comment:3 Changed 14 months ago by tekknokrat

Can you please push this patch into the plugin? I am planning to deploy wikiprint on several trac instances and would like to avoid massive patching ;-)

comment:4 Changed 14 months ago by rjollos

Yes, sorry for the delay. I'll push it today.

comment:5 Changed 14 months ago by rjollos

In 13285:

Refs #10797: Code cleanup: PEP-0008 changes, removed unused imports including unused import of pisa in web_ui.py. Removed Trac from install_requires, as this has been shown to cause problems (see #10607).

comment:6 Changed 14 months ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13286:

Fixes #10797: Update import of pisa to account for new module name. Thanks to charlie@… for the patch.

comment:7 Changed 14 months ago by rjollos

In 13287:

Refs #10797: Bumped version to 1.9.3dev.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.