Modify

Opened 2 years ago

Closed 7 weeks ago

Last modified 7 weeks ago

#10820 closed defect (fixed)

Link rules changed in Trac 1.0 (plug-in not detecting new link types)

Reported by: paulcoddington@… Owned by: glinders
Priority: normal Component: WantedPagesMacro
Severity: normal Keywords:
Cc: glinders Trac Release: 1.0

Description

A heads up that the interpretation of text as links in Trac 1.0 is somewhat different to that of previous versions.

For example:

This sentence Contains/Link/Now where it didn't before.

The phrase "Contains/Link/Now" is now considered a link by Trac 1.0, but it is not detected by WantedPagesPlugin.

Attachments (0)

Change History (6)

comment:1 Changed 15 months ago by rjollos

  • Owner changed from jfrancis to rjollos
  • Status changed from new to assigned

comment:2 Changed 15 months ago by rjollos

  • Component changed from WantedPagesPlugin to WantedPagesMacro

Renaming plugin from WantedPagesPlugin to WantedPagesMacro.

comment:3 Changed 15 months ago by rjollos

  • Cc glinders added; anonymous removed

See related discussion in trac:#11359.

comment:4 Changed 15 months ago by rjollos

  • Owner changed from rjollos to glinders

Reassigning tickets to glinders, assuming adoption request in #11491 will be approved.

comment:5 Changed 8 months ago by rjollos

I'm not sure if we discussed this before, but Trac 1.0 supports Python 2.5-2.7, Trac 1.2 will support 2.6-2.7. The use of OrderedDict in [14058] will result in the plugin only being usable with Python 2.7.

One solution would be to add the OrderedDictionary for Python 2.4 to a compat.py module:

try:
    from Collections import OrderedDict
except ImportError:
    from wantedpages.compat import OrderedDict
Version 1, edited 8 months ago by rjollos (previous) (next) (diff)

comment:6 Changed 7 weeks ago by glinders

  • Resolution set to fixed
  • Status changed from assigned to closed

This feature was added automagically in changeset r14058.

The new way of checking links incorporates this automatically, because it renders the Wiki pages first and then looks for unresolved links.

Also added changeset r14410 and r14411: These add a few test cases and remove the dependency on OrderedDict()

Last edited 7 weeks ago by glinders (previous) (diff)

Add Comment

Modify Ticket

Action
as closed The owner will remain glinders.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.