Modify

Opened 18 months ago

Last modified 17 months ago

#10866 new enhancement

Avoiding error if there is no subversion repository

Reported by: j43l1us@… Owned by: e2jk
Priority: low Component: TicketModifiedFilesPlugin
Severity: minor Keywords:
Cc: Trac Release:

Description

Hello,

I had a minor issue while setting a new trac server at my job: during tests i had an exception if TicketModifiedFilesPlugin was enabled and there was no Subversion repository linked to the Trac project, so i fixed if by testing if the 'repos' value (@line 116 in ticketmodifiedfiles.py) was equal to None :
116 repos = self.env.get_repository()
117 if repos is not None
118 for rev, time, author, message, in cursor:
... [...]
195 repos.close()

See attached file for more details

Attachments (2)

ticketmodifiedfiles.py (10.0 KB) - added by j43l1us@… 18 months ago.
the modified ticketmodifiedfiles.py
ticketmodifiedfiles.diff (7.9 KB) - added by j43l1us@… 18 months ago.
patch file for my modification

Download all attachments as: .zip

Change History (5)

Changed 18 months ago by j43l1us@…

the modified ticketmodifiedfiles.py

comment:1 follow-up: Changed 18 months ago by rjollos

Would you kindly attach your changes as a patch file? See trac:TracDev/SubmittingPatches if you are not familiar with how to do this. Thanks.

Changed 18 months ago by j43l1us@…

patch file for my modification

comment:2 in reply to: ↑ 1 ; follow-up: Changed 18 months ago by j43l1us@…

Replying to rjollos:

Would you kindly attach your changes as a patch file? See trac:TracDev/SubmittingPatches if you are not familiar with how to do this. Thanks.

Done, my apologies, I wasn't familiar with the "patch files system", this is the first time i create a ticket. Thank you for the information !

comment:3 in reply to: ↑ 2 Changed 17 months ago by rjollos

Replying to j43l1us@gmail.com:

Done, my apologies, I wasn't familiar with the "patch files system", this is the first time i create a ticket. Thank you for the information !

No apology necessary ;) Thanks for the patch! I'll try to get it pushed soon.

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.