Ticket #10866 (new enhancement)

Opened 3 months ago

Last modified 3 months ago

Avoiding error if there is no subversion repository

Reported by: j43l1us@gmail.com Assigned to: e2jk
Priority: low Component: TicketModifiedFilesPlugin
Severity: minor Keywords:
Cc: Trac Release:

Description

Hello,

I had a minor issue while setting a new trac server at my job: during tests i had an exception if TicketModifiedFilesPlugin was enabled and there was no Subversion repository linked to the Trac project, so i fixed if by testing if the 'repos' value (@line 116 in ticketmodifiedfiles.py) was equal to None : 116 repos = self.env.get_repository() 117 if repos is not None 118 for rev, time, author, message, in cursor: ... ... 195 repos.close()

See attached file for more details

Attachments

ticketmodifiedfiles.py (10.0 kB) - added by j43l1us@gmail.com on 02/12/13 16:21:31.
the modified ticketmodifiedfiles.py
ticketmodifiedfiles.diff (7.9 kB) - added by j43l1us@gmail.com on 02/13/13 10:00:12.
patch file for my modification

Change History

02/12/13 16:21:31 changed by j43l1us@gmail.com

  • attachment ticketmodifiedfiles.py added.

the modified ticketmodifiedfiles.py

(follow-up: ↓ 2 ) 02/12/13 21:39:19 changed by rjollos

Would you kindly attach your changes as a patch file? See trac:TracDev/SubmittingPatches if you are not familiar with how to do this. Thanks.

02/13/13 10:00:12 changed by j43l1us@gmail.com

  • attachment ticketmodifiedfiles.diff added.

patch file for my modification

(in reply to: ↑ 1 ; follow-up: ↓ 3 ) 02/13/13 10:04:12 changed by j43l1us@gmail.com

Replying to rjollos:

Would you kindly attach your changes as a patch file? See trac:TracDev/SubmittingPatches if you are not familiar with how to do this. Thanks.

Done, my apologies, I wasn't familiar with the "patch files system", this is the first time i create a ticket. Thank you for the information !

(in reply to: ↑ 2 ) 02/22/13 22:29:44 changed by rjollos

Replying to j43l1us@gmail.com:

Done, my apologies, I wasn't familiar with the "patch files system", this is the first time i create a ticket. Thank you for the information !

No apology necessary ;) Thanks for the patch! I'll try to get it pushed soon.

Add/Change #10866 (Avoiding error if there is no subversion repository)




Change Properties
Action