Modify

#10888 closed defect (fixed)

Mouseover dependency view does not work on Trac 1.0

Reported by: adam.dorsey@… Owned by: anbo
Priority: normal Component: ProjectPlanPlugin
Severity: normal Keywords:
Cc: rjollos, anbo Trac Release:

Description

By modifying the install_requires field in setup.py, I managed to build a version that loads under Trac 1.0.1. Everything works fine except for the pop-up that shows the contents of a ticket's dependency; instead of displaying the ticket information, it displays a long, empty box. Still not sure why this is occurring, will try to find some answers.

Attachments (0)

Change History (11)

comment:1 Changed 18 months ago by anonymous

Tracked it down to projectplanplugin/0.11/trunk/projectplan/htdocs/js/projectplan.js line 996:

$("#"+myid).load(this.href+" #content > *:lt(3)"); // works on Trac 0.12

Changing this to

$("#"+myid).load(this.href+" #ticket > *:lt(3)"); // works on Trac 0.12

gets things to partially load, but not completely.

comment:2 follow-up: Changed 18 months ago by anonymous

The following works perfectly:

$("#"+myid).load(this.href+" #ticket "); // works on Trac 1.0.1

Don't know if this still works on Trac 0.12 though.

comment:3 in reply to: ↑ 2 Changed 18 months ago by adam.dorsey@…

Replying to anonymous:

The following works perfectly:

$("#"+myid).load(this.href+" #ticket "); // works on Trac 1.0.1

Don't know if this still works on Trac 0.12 though.

So this page is Trac 0.10.6, and it still has the #ticket div. This fix should, in theory, work for 0.12 and under as well.

That last post was me BTW, forgot to enter email.

comment:4 Changed 18 months ago by rjollos

  • Cc rjollos added

comment:5 follow-up: Changed 18 months ago by rjollos

I'll treat this the same as #10882, with the two week wait. Please feel free to ping me after 2 weeks if I forget (which is likely ;)

comment:6 Changed 18 months ago by asdorsey

  • Cc anbo added

So is this the "right" way of fixing things? Change definitely works on 1.0.1; I can set up a Trac 0.12 instance to test as well if necessary. However, given the layout on older versions of Trac, it seems it will work there as well.

comment:7 in reply to: ↑ 5 Changed 18 months ago by rjollos

Replying to rjollos:

I'll treat this the same as #10882, with the two week wait. Please feel free to ping me after 2 weeks if I forget (which is likely ;)

I won't be much help with any questions since I don't use the plugin, but just wanted to follow-up and say that I won't be committing since I see recent commit activity from makadev and it seems the plugin is still maintained.

comment:8 Changed 18 months ago by anbo

  • Owner changed from makadev to anbo
  • Status changed from new to assigned

comment:9 Changed 18 months ago by anbo

Well makadev is not commiting anymore. However, there will soon be an update considering the changes of Trac 1.0.

comment:10 Changed 17 months ago by rjollos

Cool, glad to know there is still development ongoing. Thanks for your efforts :)

comment:11 Changed 16 months ago by asdorsey

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in [12974]

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.