Ticket #10897 (closed enhancement: fixed)

Opened 3 months ago

Last modified 3 months ago

Drop-down style menus don't work under Agilo: easy fix

Reported by: jmlvargas@gmail.com Assigned to: jun66j5
Priority: normal Component: TracWysiwygPlugin
Severity: normal Keywords: agilo
Cc: Trac Release: 0.12

Description

Drop-down style menus (style, TT and table) don't work under Agilo.

Agilo and this plugin both define a ".menu" css style, causing an style conflict. Changing the wysiwyg ".menu" style to something like ".wysiwyg-drop-menu" saves the day. Here is my patch file (review it before applaying).

Attachments

diff.diff (1.3 kB) - added by jmlvargas@gmail.com on 02/28/13 18:51:53.
Easy fix for drop down style menus for wysiwyg + agilo.

Change History

02/28/13 18:51:53 changed by jmlvargas@gmail.com

  • attachment diff.diff added.

Easy fix for drop down style menus for wysiwyg + agilo.

02/28/13 18:52:56 changed by anonymous

  • release set to 0.12.

02/28/13 20:14:23 changed by jun66j5

  • status changed from new to assigned.

Looks good. It would be robust to such conflicts. Thanks.

(follow-up: ↓ 4 ) 03/01/13 03:19:37 changed by jun66j5

  • type changed from defect to enhancement.

Also, Agilo should not define .menu as top level in stylesheet. Are you send the same report to Agilo developers?

(in reply to: ↑ 3 ; follow-up: ↓ 6 ) 03/01/13 14:09:49 changed by anonymous

Replying to jun66j5:

Also, Agilo should not define .menu as top level in stylesheet. Are you send the same report to Agilo developers?

No, I didn't. Have you ever seen an Agilo's css? ;)

03/04/13 17:24:24 changed by jun66j5

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [12680]) tracwysiwyg: removed .menu style from drop-down menu to avoid stylesheet conflicts with Agilo (fixed #10897)

Initial patch by jmlvargas@gmail.com. Thanks.

(in reply to: ↑ 4 ) 03/04/13 17:26:31 changed by jun66j5

Replying to anonymous:

No, I didn't. Have you ever seen an Agilo's css? ;)

Yes. .menu is defined in http://demo.agilofortrac.com/chrome/agilo/stylesheet/agilo_theme.css.

Add/Change #10897 (Drop-down style menus don't work under Agilo: easy fix)




Change Properties
Action