Opened 11 years ago

Last modified 11 years ago

#10932 closed defect

undefined variable en in auth.py line 279 — at Version 3

Reported by: darth Dingleberry Owned by: branson
Priority: normal Component: DirectoryAuthPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description (last modified by Ryan J Ollos)

Hi, First off thanks for keeping this critical plugin moving along ;-) Now my little typo find: I think this should be "e" not "en" as that makes it put out a proper error message.

Line is the raise statement:

try:
    self._ldap.simple_bind_s(self.dir_binddn, self.dir_bindpw)
except ldap.LDAPError, e:
    self.log.info('bind_ad: binding failed. %s ' % (e))
    raise TracError('cannot bind to %s: %s' % (self.dir_uri , en))

Also I would like to work on getting memberOf working as we need that functionality in order to use this tool. How would I go about making that level of contribution? I have another python tool that does most of the work already in place. Lastly we have to force referrals off to make this work, currently that means locally forked code. I would like to get that worked in as well to trunk.

Thanks, Eddie J

ps apologies for the email mixed with a bug report, not sure how to get into the "loop"

Change History (3)

comment:1 Changed 11 years ago by Ryan J Ollos

Description: modified (diff)

comment:2 Changed 11 years ago by lkraav

Yeah, confirming the typo part. It's a rather low cost patch, I wonder if sandinak could push it to the repo with some urgency? Is he still interested in the plugin?

comment:3 Changed 11 years ago by Ryan J Ollos

Description: modified (diff)
Note: See TracTickets for help on using tickets.