database bugs: wrong table name and failure to escape single quotes
|Reported by:||kyle.james.oconnor@…||Owned by:||sandinak|
I just installed your plugin using easy_install from the trunk and I got warnings about non-existant table 'ad_cache' because it has been changed to 'dir_cache'. Also, you aren't using prepared statements for your SQL commands and therefore you have not escaped necessary characters such as single quote. Since this is an AD plugin and names (like mine) can have apostrophes, it needs a fix. Otherwise, very nice plugin.
I attached a patch where I fixed these things quick and dirty in my environment.
Change History (15)
comment:3 Changed 9 months ago by rjollos
- Owner changed from sandinak to rjollos
- Status changed from new to assigned
comment:5 Changed 9 months ago by rjollos
- Resolution set to fixed
- Status changed from assigned to closed
comment:11 Changed 8 months ago by rjollos
- Resolution fixed deleted
- Status changed from closed to reopened