Modify

#11035 closed defect (worksforme)

mysql-specific SQL [patch]

Reported by: marc@… Owned by: anbo
Priority: normal Component: ProjectPlanPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

The ppreport code contains 3 mysql-specific parts which can easily be made generic.

Attaching patch.

Attachments (1)

sql-limit-fix.patch (1.7 KB) - added by marc@… 20 months ago.
SQL portability patch

Download all attachments as: .zip

Change History (5)

Changed 20 months ago by marc@…

SQL portability patch

comment:1 Changed 20 months ago by rjollos

  • Owner changed from makadev to anbo

I changed the Component owner just now so that new tickets will be assigned to anbo (current maintainer).

comment:2 Changed 20 months ago by rjollos

The Trac database API should be utilized according to t:TracDev/DatabaseApi#RulesforDBAPIUsage. String formatting should not be used to pass arguments to SQL statements, as it will cause cross-DB compatibility issues.

comment:3 Changed 20 months ago by anbo

(In [13069]) v1.1.2, patch release

solved the MySQL specific issues, refs #11035

thanks to marc@your.tv for the patch

comment:4 Changed 20 months ago by anonymous

  • Resolution set to worksforme
  • Status changed from new to closed

I changed the queries as the patch implied.

Changing all the SQL queries is not as easy. However, thanks to rjollos for making the constraints clear.

Add Comment

Modify Ticket

Action
as closed The owner will remain anbo.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.