Modify

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#11036 closed enhancement (fixed)

Use Option class for defining options

Reported by: rjollos Owned by: Graham_Miln
Priority: normal Component: MilnCheckboxPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

Cool plugin! I have a minor suggested improvement, which can be found in the attached patch.

If you use the Option class, and provide documentation, it will display on the TracIni page:


The patch also fixes a few PEP8 violations.

Attachments (2)

TracIni.png (15.7 KB) - added by rjollos 15 months ago.
t11036.diff (1.7 KB) - added by rjollos 15 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 15 months ago by rjollos

  • Reporter changed from anonymous to rjollos

Changed 15 months ago by rjollos

Changed 15 months ago by rjollos

comment:2 Changed 15 months ago by rjollos

Btw, the patch is not quite complete. The placeholders Put some documentation here need to be replaced with real documentation.

comment:3 Changed 15 months ago by Graham_Miln

  • Status changed from new to assigned

comment:4 Changed 15 months ago by Graham_Miln

  • Resolution set to fixed
  • Status changed from assigned to closed

Thank you for the patch; I appreciate your looking over the code.

Fixed in r13008.

comment:5 Changed 15 months ago by rjollos

Sure, no problem. I might have a few other suggestions related to how the markup strings are generated. I'll see if I can find time to take another look.

Have you been working with Trac and Python for long? I'm always curious as to how people are using Trac, particularly plugin authors.

Hint: You can use t:CommitTicketUpdater to have commit messages inserted into ticket. For example, add Refs #11036 or Fixes #11036 in your commit message. You can see some examples in various tickets, such as #10218.

comment:6 Changed 15 months ago by Graham_Miln

Thank you. I have responded via e-mail to your questions.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from Graham_Miln. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.