Modify

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#11072 closed task (fixed)

Install as a package that includes OpenFlashChart2

Reported by: rjollos Owned by: rjollos
Priority: normal Component: TicketChartsMacro
Severity: normal Keywords:
Cc: aviram, ivanelson, hasienda Trac Release:

Description (last modified by rjollos)

The installation steps are too complex, see comment:13:ticket:6061. The plugin should be installable using setuptools, and !OpenFlashChart2 should be bundled.

Attachments (0)

Change History (35)

comment:1 Changed 11 months ago by rjollos

  • Cc ivanelson added

comment:2 Changed 11 months ago by rjollos

  • Description modified (diff)
  • Summary changed from Install as a package that includes OpenFlashCharts to Install as a package that includes OpenFlashChart2

comment:3 Changed 11 months ago by rjollos

(In [13116]) Refs #11072: Created a package installer and bundled !OpenFlashChart2 into the package.

comment:4 Changed 11 months ago by rjollos

(In [13117]) Refs #11072: Renamed 0.11 directory to trunk.

comment:5 Changed 11 months ago by rjollos

(In [13118]) Refs #11072: Created a tags directory.

comment:6 Changed 11 months ago by rjollos

Plugin and all of its dependencies can now be installed using setuptools, following the methods described at t:TracPlugins.

comment:7 Changed 11 months ago by rjollos

(In [13149]) Refs #11072: Fixed error in [13116]. Package data was not being installed because package name was incorrectly specified as ticketstats rather than ticketcharts in specification.

comment:8 follow-up: Changed 11 months ago by ivanelson

Was solved by copying the folder "htdocs" directory "trunk". With that no exception was raised. However the graph only show a yellow background and title.

WARNING: File js/json/json2.js not found in  any of ['/usr/local/lib/python2.7/dist-packages/TracTicketCharts-0.2dev-py2.7.e gg/ticketcharts/htdocs']
  • Other errors:
    Error: Macro TicketChart(type = stacked_bars, key = owner, x_axis = status, query = milestone="MZOP1", title = Tickets by status and owner for MZOP1) failed
    max() arg is an empty sequence
    

comment:9 in reply to: ↑ 8 Changed 11 months ago by rjollos

Replying to ivanelson:

Was solved by copying the folder "htdocs" directory "trunk".

That should be fixed with [13149] too.

With that no exception was raised. However the graph only show a yellow background and title.

I'll do some more testing and get back to you.

comment:10 follow-up: Changed 11 months ago by ivanelson

How is your "trac.ini" -> [ticket-charts] ?

Sometimes I see "HttpNotFound" in "trac.log":

2013-05-16 00:02:10,732 Trac[main] WARNING: [200.XX.XX.XX] HTTPNotFound: 404 Not
 Found (File js/json/json2.js not found)

comment:11 in reply to: ↑ 10 Changed 11 months ago by rjollos

Replying to ivanelson:

How is your "trac.ini" -> [ticket-charts] ?

It shouldn't be necessary to specify any parameters in the ticket-charts section of trac.ini. The only two remaining options now are the defaults for height and width.

I see some other issues with the plugin that I'm working to resolve and should have a new version available tomorrow.

comment:12 Changed 11 months ago by rjollos

(In [13161]) Refs #11072: Fix traceback when the query returned no results. The x and y axes limits are not set when the query returns no results.

comment:13 Changed 11 months ago by rjollos

(In [13164]) Refs #11072: Fixed traceback when key was not specified for a bar chart. The key is now optional.

comment:14 Changed 11 months ago by rjollos

ivanelson: Please test again and let me know how it's working for you.

Note: Parameters should not be quoted. Previously the wiki page stated It is important that everything in the query's parameters will be under quotes. I've updated the wiki page to correct the examples.

comment:15 follow-ups: Changed 11 months ago by ivanelson

I downloaded the new version and the result of the tests was:

  • 1. The plugin did not work! The search path of the folder "json" assigned to the parameter "package_data" in setup.py is wrong. (I resolved this issue on my local version and installed it again after it worked)
      package_data = {'ticketcharts': [
             'htdocs/*.swf',
             'htdocs/js/*.js'
             'htdocs/js/json/*.js']
         }
    
  • 2. Still there is this limitation:
    TicketCharts.py
    # TODO: Fill more colors
    COLOURS = ['# 356AA0', '# 35a345', '# C711F0', '# C79810', '# D037fC', '# D01F3C']
    
  • 3. I tried to send my setup.py file fixed, but I could not! SVN not accept the return. I have a password on the site trac-hacks. But I've never done this before in svn + trac-hacks. :(

In short! Is working as expected.

Thank you.

comment:16 in reply to: ↑ 15 Changed 11 months ago by rjollos

Replying to ivanelson:

  • 1. The plugin did not work! The search path of the folder "json" assigned to the parameter "package_data" in setup.py is wrong. (I resolved this issue on my local version and installed it again after it worked)

Thanks, I will fix that.

comment:17 in reply to: ↑ 15 Changed 11 months ago by rjollos

Replying to ivanelson:

  • 2. Still there is this limitation:

There's a patch for that issue in #9254.

comment:18 Changed 11 months ago by rjollos

(In [13175]) Refs #11072: package_data was incorrect for files in js/json. Eliminated json subdirectory and moved json2.js in parent js directory.

comment:19 Changed 11 months ago by rjollos

(In [13176]) Refs #11072: Part of [13175]. Directories don't get deleted in Git, so it seems to be necessary to remove them directly in SVN.

comment:20 Changed 11 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

comment:21 follow-up: Changed 11 months ago by ivanelson

Hi rjollos,

To contribute a Hack. Where do I start? What do I need?

comment:22 follow-up: Changed 11 months ago by rjollos

Would you like to post a new hack, or contribute some code to an existing hack?

comment:23 in reply to: ↑ 22 ; follow-ups: Changed 11 months ago by ivanelson

Replying to rjollos:

Would you like to post a new hack, or contribute some code to an existing hack?

I want to learn the 02 cases.

comment:24 in reply to: ↑ 23 Changed 11 months ago by rjollos

  • Cc hasienda added

Replying to ivanelson:

Replying to rjollos:

Would you like to post a new hack, or contribute some code to an existing hack?

I want to learn the 02 cases.

One side hint first - when you prefix your comment with >>, it gives it the styling of a "reply to a reply". Typically that would look like this,

>> First comment
> Reply to first comment
Reply to reply to first comment

First comment

Reply to first comment

Reply to reply to first comment

However, you've been commenting like this, which makes it a bit confusing to read,

> First comment
>> Reply to first comment

First comment

Reply to first comment

Anyway, I've corrected your previous comment to remove the >>.

comment:25 in reply to: ↑ 23 ; follow-up: Changed 11 months ago by rjollos

Replying to ivanelson:

Replying to rjollos:

Would you like to post a new hack, or contribute some code to an existing hack?

I want to learn the 02 cases.

If you'd like to contribute to a plugin, just open a ticket and post a patch, or post a patch to an existing ticket. If there is a plugin that needs a maintainer and your patches look good, then you can take over that plugin.

Officially our policy right now is that anyone can adopt an unmaintained hack, however due to some issues with some individuals adopting hacks and making an absolute mess of them, I'd really like to change that policy with input from the community. I'd like the new policy to be that unmaintained hacks become "adopted by the trachacks community", and the core committers are responsible for determining if someone has sufficient skills to further develop a hack. I don't think we need a high bar to adopting a hack, I just don't like that anyone can take over a hack on a "first come first serve basis", even if they are unqualified, and/or will make a complete mess of it and then leave. The "first come, first serve" issue bothers me the most, because our policy at the moment implies that the first person to request adoption of a hack can take it over and block anyone else from contributing if they choose. Once the original author has passed a hack off to the community by saying that it can be adopted, I think that any qualified member of the community should be able to contribute to the hack.

So, with that said, you are welcome to adopt hacks because that is our official policy, but I'd also urge you to post some patches first, and I'm happy to help you improve them if you are new to trac-hacks development. We'd love to have you onboard and contributing, and I'm happy to help any way that I can.

If you have a new hack that you've developed, you can create a new project from the NewHack page.

comment:26 in reply to: ↑ 21 ; follow-up: Changed 11 months ago by rjollos

Replying to ivanelson:

Hi rjollos,

To contribute a Hack. Where do I start? What do I need?

Also, to setup a development environment, check out t:TracDev/DevelopmentEnvironmentSetup.

comment:27 in reply to: ↑ 25 Changed 11 months ago by ivanelson

Replying to rjollos:

Replying to ivanelson:

Replying to rjollos:

Would you like to post a new hack, or contribute some code to an existing hack?

I want to learn the 02 cases.

If you'd like to contribute to a plugin, just open a ticket and post a patch, or post a patch to an existing ticket ....

I am happy to count the support. I have never worked professionally with Python, especially something big like Trac.

I am manager of a development team and we are using Trac, a few months ago. So this support is very important in the future I can allocate some member of my staff to actively contribute in the hacks. Meanwhile, here I am, trying to understand and help this great organism that is Trac.

comment:28 in reply to: ↑ 26 Changed 11 months ago by ivanelson

Replying to rjollos:

Replying to ivanelson:

Hi rjollos,

To contribute a Hack. Where do I start? What do I need?

Also, to setup a development environment, check out t:TracDev/DevelopmentEnvironmentSetup.

I have this configured environment. However I have never been apart. I need to know what each package does. Following the execution stack Trac.

comment:29 follow-up: Changed 11 months ago by ivanelson

When used with custom fields, the plugin returns the url query the value of None for Tickets not set a value for the custom field.

For example have a field with name "Project". However many tickets does not have a value defined in the base data for the field.

You can return the value "" or white instead of "None"?

This behavior was seen in the graph pie. When you click on the slice of the graph that has no defined value.

comment:30 in reply to: ↑ 29 Changed 11 months ago by rjollos

Replying to ivanelson:

When used with custom fields, the plugin returns the url query the value of None for Tickets not set a value for the custom field.

Just so I can be sure, could you post a sample macro call?

For example have a field with name "Project". However many tickets does not have a value defined in the base data for the field.

You can return the value "" or white instead of "None"?

Yeah, I think that makes sense. I'll take a look tomorrow.

This behavior was seen in the graph pie. When you click on the slice of the graph that has no defined value.

In the future, feel free to open a new ticket for issues like this.

comment:31 follow-up: Changed 11 months ago by rjollos

(In [13248]) Refs #11072: Avoid values of 'None' in query string for "clickable link" when value should be an empty string.

comment:32 in reply to: ↑ 31 Changed 11 months ago by ivanelson

Replying to rjollos:

(In [13248]) Refs #11072: Avoid values of 'None' in query string for "clickable link" when value should be an empty string.

See: http://mysite.mydomain.com.br/query?order=priority&project=None Where 'project' is a custom field used by [1]SimpleMultiProject.

[1] http://trac-hacks.org/wiki/SimpleMultiProjectPlugin

comment:33 follow-up: Changed 11 months ago by rjollos

The issue should be resolved now. Please let me know if you still see the error after upgrading.

comment:34 Changed 11 months ago by rjollos

(In [13250]) Refs #6904, #11072: Refactoring and improved backward compatibility for changes in [13247] and [13248], suggested by Jun Omae (jun66j5).

comment:35 in reply to: ↑ 33 Changed 11 months ago by ivanelson

Replying to rjollos:

The issue should be resolved now. Please let me know if you still see the error after upgrading.

Fixed! Passed the test.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from rjollos. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.