Modify

Opened 19 months ago

Closed 19 months ago

Last modified 17 months ago

#11085 closed task (fixed)

Plugin lacks a license

Reported by: rjollos Owned by: framay
Priority: normal Component: AttachmentPolicyPlugin
Severity: normal Keywords: license
Cc: hasienda Trac Release:

Description

Hi, I noticed that there isn't a license specified in setup.py. Did you have a particular license in mind? You might consider using the BSD 3-Clause license, as Trac does.

Would you consider?:

  • Adding license headers to each file.
  • Adding a COPYING file with the license text.
  • Specifying the license as an argument to setup in setup.py.

I'd be happy to take care of these activities if you give the go-ahead and indicate your license preference.

Attachments (0)

Change History (8)

comment:1 Changed 19 months ago by rjollos

  • Keywords license added

comment:2 follow-up: Changed 19 months ago by framay

I am glad, that you are interested in my plugin. Feel free to add the license. I would prefer "THE BEER-WARE LICENSE" as I already put in RoadmapPlugin (see revision [11151]).

comment:3 in reply to: ↑ 2 Changed 19 months ago by hasienda

Replying to framay:

I am glad, that you are interested in my plugin. Feel free to add the license. I would prefer "THE BEER-WARE LICENSE" as I already put in RoadmapPlugin (see revision [11151]).

Sorry, but from a legal point of view this is not a real license, and this really matters, because licensing is business, no child-play, anyway. You may trust me, read more on the issues with this coder attitude disclaimer in a recent ticket for AccountManagerPlugin [1], or research the web on your own.

I'm coming a long way from Debian, and these guys tend to take legal stuff very serious. For what its worth I hope to convince you to move your preferences towards any of the common recognized free licenses like Apache, 3-clause BSD or MIT. I'm sure, this is what will serve all of us developers and users most in the long run. But certainly more discussion is welcome.

Thanks for consideration.

Steffen Hoffmann

[1] #10644, especially see the attachment

20121121_AcctMgr_add-real-license_appeal.pdf:ticket:10644 in there

Last edited 17 months ago by rjollos (previous) (diff)

comment:4 Changed 19 months ago by framay

Well, when I recall correctly, I copied the BEERWARE from the AccountManagerPlugin. But it seems before ticket #10644. I am also fine with the 3-BSD license.

Thanks again for taking care about these topics.

comment:5 Changed 19 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

(In [13152]) Fixes #11085:

  • Added BSD 3-Clause license with permission of author, adding license text in a COPYING file and adding headers to source code.
  • Tidied up setup,py. Changed url to point to trac-hacks since this variable affects where defects are reported in the case that the user creates a ticket using the button on the Internal Error page.

comment:6 follow-ups: Changed 19 months ago by rjollos

Thanks for working that out guys. I also prefer the BSD 3-Clause so that there is no ambiguity, and it seems safest given the little I know about licenses.

I tidied up setup.py, but let me know if you'd like anything to be different than what I've done. I did some quick testing to check that everything is okay after the changes.

Have you considered also adding a WIKI_ATTACHMENT_DELETE permission? It seems like a staightforward extension of this plugin.

comment:7 in reply to: ↑ 6 Changed 19 months ago by framay

Replying to rjollos:

Thanks for working that out guys. I also prefer the BSD 3-Clause so that there is no ambiguity, and it seems safest given the little I know about licenses.

Same for me. Thank you, Steffen.

I tidied up setup.py, but let me know if you'd like anything to be different than what I've done. I did some quick testing to check that everything is okay after the changes.

Thanks for taking care about that.

Have you considered also adding a WIKI_ATTACHMENT_DELETE permission? It seems like a staightforward extension of this plugin.

When I remember correctly the TICKET_ATTACHMENT_DELETE is also working for wiki attachments. Because at line 40-42 of attachment_policy.py I do not check the resource type.

But it seems to be more consistent having a WIKI_ATTACHMENT_DELETE permission. Another option would be to rename permission to ATTACHMENT_DELETE (maybe two permissions are too much for that issue?).

comment:8 in reply to: ↑ 6 Changed 19 months ago by framay

Replying to rjollos:

Have you considered also adding a WIKI_ATTACHMENT_DELETE permission? It seems like a staightforward extension of this plugin.

I guess ticket #9276 already requests what you want.

Add Comment

Modify Ticket

Action
as closed The owner will remain framay.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.