Modify

#11154 closed defect (fixed)

AttributeError: 'TracHacksHtPasswdStore' object has no attribute 'user_email_verification_requested'

Reported by: rjollos Owned by: hasienda
Priority: normal Component: TracHacksPlugin
Severity: normal Keywords:
Cc: ivanelson, ChrisNelson Trac Release:

Description

Two users have reported this issue. It appears to be due to the HtPasswdStore implementation in TracHacksPlugin not having been adapted to the AccountManagerPlugin 0.4 API (IAccountChangeListener).

Attachments (0)

Change History (6)

comment:1 Changed 15 months ago by rjollos

In 13272:

Refs #11154: Added pass-through implementations of two missing IAccountChangeListener methods (for AccountManagerPlugin 0.4.3).

comment:2 follow-up: Changed 15 months ago by rjollos

[13271] was just a quick workaround until we get some real expertise (hasienda) on the problem.

comment:3 in reply to: ↑ 2 ; follow-up: Changed 15 months ago by hasienda

Replying to rjollos:

[13271] was just a quick workaround until we get some real expertise (hasienda) on the problem.

Approved. Accidentally I've been planning a major rework of the change listener interface in question. But didn't search for existing implementations yet. Once finished, it will no longer blew-up when calling older listeners that naturally will miss methods or have incompatible method signatures.

comment:4 follow-up: Changed 15 months ago by ChrisNelson

When logging in I see:

An email has been sent to with a token to verify your new email address.

but the e-mail never showed up. Still, I seem to be able to use the system.

comment:5 in reply to: ↑ 4 Changed 15 months ago by hasienda

Replying to ChrisNelson:

When logging in I see:

An email has been sent to with a token to verify your new email address.

but the e-mail never showed up. Still, I seem to be able to use the system.

A bit strange indeed. First, there is no email. It should be mentioned in the text between "has been sent to" and "with a token", but it is not. Second, until providing the valid verification token you should all elevated permissions should be stripped from the authenticated session, with an exception for admin users, but that group should not be challenged in the first place. Btw, any regular user will get challenged again after changing a verified address.

comment:6 in reply to: ↑ 3 Changed 14 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

Replying to hasienda:

Approved. ...

I'll go ahead and close then, but please reopen if you think there should be additional work done related to this ticket.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.