Modify

#11170 closed defect (fixed)

Reset width and height of textarea after changing orders of custom fields

Reported by: jun66j5 Owned by: jun66j5
Priority: normal Component: CustomFieldAdminPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.12

Description

How to reproduce

  1. Add custom field as textarea with 42 for width and 3 for height
  2. Visit "Manage Custom Fields" panel and click "Apply changes" button
  3. Reset cols and rows of the field to default

TicketSystem.get_custom_fields() returns width and height property in a ditionary for textarea type. However, the properties are field-name.cols and field-name.rows in trac.ini. Therefore, the plugin doesn't keep the values.

customfieldadminplugin-r13282.diff, unit tests pass on Trac 0.11.3 - 1.0.1.

Attachments (1)

customfieldadminplugin-r13282.diff (4.0 KB) - added by jun66j5 13 months ago.

Download all attachments as: .zip

Change History (4)

Changed 13 months ago by jun66j5

comment:1 Changed 13 months ago by jun66j5

Another thing is that the cols field gets focus after clicking the rows field on Firefox. The patch includes the fix for it.

comment:2 Changed 13 months ago by anonymous

  • Owner changed from osimons to jun66j5

Thank - looks good to me. Jun, feel free to commit this yourself.

Version 0, edited 13 months ago by anonymous (next)

comment:3 Changed 13 months ago by jun66j5

  • Resolution set to fixed
  • Status changed from new to closed

In 13289:

CustomFieldAdminPlugin: Keep width and height of textarea type when custom fields are ordered and fixed the label element for rows field. Closes #11170.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from jun66j5. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.