Modify

Opened 15 months ago

Closed 9 months ago

Last modified 9 months ago

#11184 closed defect (fixed)

The button to choose files for reviewing is missing

Reported by: aneesme@… Owned by: olemis
Priority: normal Component: PeerReviewPlugin
Severity: major Keywords:
Cc: rjollos Trac Release: 1.0

Description

I just set up the PeerReview Plugin and when accessing the Peer Review plugin I am not able to see the button to choose the files for reviewing. I have no idea how I can link the PeerReview plugin with the SVN code base which is currently integrated with the Trac setup.

Attachments (0)

Change History (13)

comment:1 in reply to: ↑ description Changed 15 months ago by anonymous

Replying to aneesme@…:

I just set up the PeerReview Plugin and when accessing the Peer Review plugin I am not able to see the button to choose the files for reviewing. I have no idea how I can link the PeerReview plugin with the SVN code base which is currently integrated with the Trac setup.

What versions of Trac and SVN are you using ?

comment:2 Changed 15 months ago by anonymous

$ svnserve --version
svnserve, version 1.6.6 (r40053)

compiled Jun 5 2011, 14:51:47

$ tracd --version
tracd 1.0.1

Version 0, edited 15 months ago by anonymous (next)

comment:3 Changed 15 months ago by olemis

  • Trac Release set to 1.0

Thanks for reporting this issue. Support for Trac>=1.0 is planned for 2013 Q3 .

comment:4 follow-up: Changed 12 months ago by julien.gresse@…

Hello,

I've got the same issue but different configuration:

/var/www/trac# tracd --version
tracd 0.11.1

Do you have a hint to avoid this problem ?
I see tha 'browserArea' is empty in the HTML code. I could give you more details if needed.
Thanks

Last edited 9 months ago by rjollos (previous) (diff)

comment:5 in reply to: ↑ 4 ; follow-up: Changed 12 months ago by olemis

Replying to julien.gresse@…:
[...]

I see tha 'browserArea' is empty in the HTML code. I could give you more details if needed.

Would be nice to know more details about the deployment and also if anything is written in the logs .

Thanks

PS: BTW , I'm prioritizing now the improvements for XmlRpcPlugin , so 2013 Q3 schedule might be deferred until Q4 ... though I'm hoping to work on this a bit sooner than that.

comment:6 in reply to: ↑ 5 ; follow-up: Changed 12 months ago by anonymous

Replying to olemis:

Replying to julien.gresse@…:
[...]

I see tha 'browserArea' is empty in the HTML code. I could give you more details if needed.

Would be nice to know more details about the deployment and also if anything is written in the logs .

Thanks

PS: BTW , I'm prioritizing now the improvements for XmlRpcPlugin , so 2013 Q3 schedule might be deferred until Q4 ... though I'm hoping to work on this a bit sooner than that.

Hi,
I've downloaded source package: peerreviewplugin-13386.zip, unzip it and use setup.py bdist-egg command to build egg. Then I moved the egg to the directory plugins of my trac project, upgrade project and add component to trac.ini. I saw the new menu in my trac project, add permissions to users but the file selection is empty.

Nothing special in the log but I have two errors in my browser: its searching for http://server/trac-mysql/chrome/common/css/code.css and http://server/trac-mysql/chrome/common/css/browser.css --> Do I need another plugin to make it work ?

Thanks

comment:7 in reply to: ↑ 6 ; follow-up: Changed 12 months ago by olemis

Replying to anonymous:

Replying to olemis:

Replying to julien.gresse@…:

[...]

I've downloaded source package: peerreviewplugin-13386.zip, unzip it and use setup.py bdist-egg command to build egg. Then I moved the egg to the directory plugins of my trac project, upgrade project and add component to trac.ini. I saw the new menu in my trac project, add permissions to users but the file selection is empty.

I see ...

Nothing special in the log but I have two errors in my browser: its searching for http://server/trac-mysql/chrome/common/css/code.css and http://server/trac-mysql/chrome/common/css/browser.css --> Do I need another plugin to make it work ?

No other plugin is needed. That's definitely a bug .

comment:8 in reply to: ↑ 7 ; follow-up: Changed 12 months ago by julien.gresse@…

Replying to olemis:

Replying to anonymous:

Replying to olemis:

Replying to julien.gresse@…:

[...]

I've downloaded source package: peerreviewplugin-13386.zip, unzip it and use setup.py bdist-egg command to build egg. Then I moved the egg to the directory plugins of my trac project, upgrade project and add component to trac.ini. I saw the new menu in my trac project, add permissions to users but the file selection is empty.

I see ...

Nothing special in the log but I have two errors in my browser: its searching for http://server/trac-mysql/chrome/common/css/code.css and http://server/trac-mysql/chrome/common/css/browser.css --> Do I need another plugin to make it work ?

No other plugin is needed. That's definitely a bug .

Another question: the span "browserArea" is empty, maybe it's the true issue ?

comment:9 in reply to: ↑ 8 Changed 12 months ago by olemis

Replying to julien.gresse@…:

[...]

Another question: the span "browserArea" is empty, maybe it's the true issue ?

That's not looking good either . I'll see what I can do to start working on this tickeet asap.

comment:10 Changed 9 months ago by dm@…

I have been digging through the source and found that the main reason this isn't displaying is because getBrowser(browserCallback) is never actually called when the page loads. It looks like it used to in a former iteration but got removed (possibly accidentally) in r12487. Running the function manually results in an error of:

AttributeError: 'NoneType' object has no attribute 'youngest_rev'

I'm going to see if there's an easy way around that, as I really want to be able to use this plugin. I don't know Python at all though so I'm not sure how much progress I'm going to make.

comment:11 follow-up: Changed 9 months ago by anonymous

I added getBrowser(browserCallback); to the bottom of htdocs/js/peerReviewNew.js, then applied the multi-repo patch at http://trac-hacks.org/attachment/ticket/7034/multiple-repo.patch which fixed the above error, and edited the template files to remove trac-mysql from the CSS includes. After doing all that, it seems that the code review plugin works on 1.0.1.

One problem I have found is attaching files in comments does not work, but that isn't something we really use here so it's not a huge deal for me.

comment:12 Changed 9 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

In 13496:

Restore line accidentally removed in r12487. Fixes #11184.

Thanks for dm@… for the patch.

comment:13 in reply to: ↑ 11 Changed 9 months ago by rjollos

Replying to anonymous:

and edited the template files to remove trac-mysql from the CSS includes. After doing all that, it seems that the code review plugin works on 1.0.1.

That issue is reported in #10729 and I'll go ahead and fix it now.

The fixes from #7034 have also been pushed. Unfortunately I think you'll continue to find major problems with this plugin, but I appreciate if you can test the latest and continue reporting issues.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.