Modify

Opened 14 months ago

Closed 14 months ago

Last modified 13 months ago

#11191 closed defect (duplicate)

Use plugin's own permissions instead of WIKI_* for TagsPlugin integration

Reported by: hasienda Owned by: Blackhex
Priority: normal Component: ScreenshotsPlugin
Severity: normal Keywords: tagging
Cc: hasienda, rjollos Trac Release:

Description

While the plugin defines a lot of permission action in tracscreenshots.core, it doesn't consequently use them, especially not in the optional ScreenshotsTagProvider component in 'tracscreenshots.tags'.

Attachments (1)

20130623_fx-tagperms.patch (1.6 KB) - added by hasienda 14 months ago.
proposed patch to actually check for 'SCREENSHOTS_*' permissions

Download all attachments as: .zip

Change History (4)

Changed 14 months ago by hasienda

proposed patch to actually check for 'SCREENSHOTS_*' permissions

comment:1 follow-up: Changed 14 months ago by hasienda

Ryan, IIRC you've been given plugin maintenance privileges by the author himself. Would you take care for this and future tickets, or may I accompany you in caring for this nice hack?

comment:2 Changed 14 months ago by hasienda

  • Resolution set to duplicate
  • Status changed from new to closed

This has been reported by myself in #10940. But I'll aim at resolving it according to the more elaborated approach in the patch published here.

comment:3 in reply to: ↑ 1 Changed 13 months ago by rjollos

Replying to hasienda:

Ryan, IIRC you've been given plugin maintenance privileges by the author himself. Would you take care for this and future tickets, or may I accompany you in caring for this nice hack?

Yes, please feel free to proceed however you like. I might have pushed a few patches for the plugin, but I don't have current plans to maintain it long term, and I'm not currently using it.

p.s. Sorry for the delayed reply!

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.