Modify

Opened 16 months ago

Closed 2 months ago

Last modified 2 months ago

#11205 closed defect (fixed)

Tags of some plugin are broken

Reported by: matobaa Owned by: otaku42
Priority: normal Component: TracHacks
Severity: normal Keywords:
Cc: rjollos, hasienda Trac Release:

Description

Tags of some plugin are broken. It seems be overwritten by spam. TagsPlugin on this site should store changes.


Attachments (0)

Change History (12)

comment:2 Changed 16 months ago by jun66j5

  • Cc rjollos hasienda added

comment:4 Changed 16 months ago by hasienda

For getting back former tags the only hope is to read a db backup from before the SPAM overwrite.

In general tags are currently version-less, and they where ever before. While SPAM is a valid argument for adding versions as demanded by #2429 for years, the design of an appropriate implementation raises some questions.

comment:5 Changed 12 months ago by hasienda

Consider the proposed patch in #2429 for tag revision support to become available soon.

comment:6 Changed 12 months ago by hasienda

In 13428:

TagsPlugin: Introduce tag version recording, requires db upgrade, refs #2429.

This will especially help recovering tags after SPAM tagging, refs #11205.
Therefore configurable behavior enables tracking of wiki page tag changes, but
excludes ticket keywords changes by default.

comment:7 Changed 10 months ago by rjollos

Let me know when you feel that the tag versioning added to TagsPlugin is stable, and I'll then go ahead and upgrade TagsPlugin on trac-hacks.

comment:8 in reply to: ↑ 3 ; follow-ups: Changed 10 months ago by rjollos

Replying to jun66j5:

The following pages have the same issue which is spam tagging and wiki page doesn't exist.

Any idea of the best way to deal with those pages? I'm thinking that we need a script to remove orphaned tags from the database. We should also make sure that tags are deleted when wiki pages are deleted so that this issue can't occur again.

comment:9 in reply to: ↑ 8 ; follow-up: Changed 10 months ago by hasienda

Replying to rjollos:

Replying to jun66j5:

The following pages have the same issue which is spam tagging and wiki page doesn't exist.

Any idea of the best way to deal with those pages? I'm thinking that we need a script to remove orphaned tags from the database.

Yes, but ...

We should also make sure that tags are deleted when wiki pages are deleted so that this issue can't occur again.

This is guaranteed by using wiki page change listener support that has been there since 0.6, so we'll should check an trace of db insanity more closely.

comment:10 in reply to: ↑ 8 Changed 2 months ago by rjollos

Replying to rjollos:

Replying to jun66j5:

The following pages have the same issue which is spam tagging and wiki page doesn't exist.

Any idea of the best way to deal with those pages?

It was possible to get rid of those tags by creating and then deleting the page.

I looked over the tags page and found a few more spam entries, but it could use another review: tags.

comment:11 in reply to: ↑ 9 ; follow-up: Changed 2 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

Replying to hasienda:

We should also make sure that tags are deleted when wiki pages are deleted so that this issue can't occur again.

This is guaranteed by using wiki page change listener support that has been there since 0.6, so we'll should check an trace of db insanity more closely.

It appears that all of the issues in this ticket are resolved, but it would be good to check that tags can't be added to non-existent wiki pages in some way, as you suggest. The issue we were seeing might just be from an earlier implementation of TagsPlugin that wasn't as robust as what we are running now.

The feature in #11661 would be valuable as a next step to help with hunting down spam entries.

comment:12 in reply to: ↑ 11 Changed 2 months ago by hasienda

Replying to rjollos:

Replying to hasienda:

We should also make sure that tags are deleted when wiki pages are deleted so that this issue can't occur again.

This is guaranteed by using wiki page change listener support that has been there since 0.6, so we'll should check an trace of db insanity more closely.

It appears that all of the issues in this ticket are resolved, but it would be good to check that tags can't be added to non-existent wiki pages in some way, as you suggest.

I fail to see, when I suggested that, anyway IWikiPageManipulator method tagsplugin/tags/0.7/tractags/wiki.py#L123 WikiTagInterface.validate_wiki_page evaluates page properties that cannot exist for a non-existent Wiki page, so I see no potential issue in the current design.

The issue we were seeing might just be from an earlier implementation of TagsPlugin that wasn't as robust as what we are running now.

Oh, these are/were likely remains of deleted or moved pages before re-parenting (IWikiChangeListener method wiki_page_renamed) and deleting (IWikiChangeListener method wiki_page_deleted) of Wiki page tags had been introduces more recently.

Last edited 2 months ago by rjollos (previous) (diff)

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.