Modify

Opened 17 months ago

Last modified 8 days ago

#11213 accepted defect

The username input doesn't have focus when the page loads

Reported by: rjollos Owned by: hasienda
Priority: normal Component: AccountManagerPlugin
Severity: minor Keywords:
Cc: Trac Release: 0.11

Description (last modified by rjollos)

Tested with Trac 0.11 and Trac 1.0.2. The focus is placed on the #username input in 0.11, but not in Trac 1.0.2. The patch that follows has been tested in both Trac 0.11 and 1.0.2 and works correctly for both cases.

Attachments (1)

t11213.diff (1.0 KB) - added by rjollos 17 months ago.
Patch against r13290 of the trunk.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 17 months ago by rjollos

  • Description modified (diff)

Changed 17 months ago by rjollos

Patch against r13290 of the trunk.

comment:2 Changed 17 months ago by rjollos

The /reset_password page has the same issue.

Version 0, edited 17 months ago by rjollos (next)

comment:3 Changed 17 months ago by hasienda

In 13323:

AccountManagerPlugin: Set sensible focus to an input field on page load, refs #11213 and #11215.

Template improvements are done too, mainly following valuable suggestions by
Jun and Ryan - thanks to both of you.

comment:4 in reply to: ↑ description Changed 17 months ago by hasienda

Replying to rjollos:

... has been tested in both Trac 0.11 and 1.0.2 and works correctly for both cases.

Thank you very much for taking care.

comment:5 Changed 17 months ago by rjollos

I'm not seeing that this causes a problem, but for consistency we might want to remove the [0] on the two remaining instances:

user@ubuntu:~/Workspace/trachacks.git$ grep -R "\[0\].focus()" accountmanagerplugin/trunk
accountmanagerplugin/trunk/acct_mgr/templates/verify_email.html:        $('#token')[0].focus();
accountmanagerplugin/trunk/acct_mgr/templates/login.html:        $('#username')[0].focus();

comment:6 Changed 8 days ago by hasienda

  • Status changed from new to accepted

comment:7 Changed 8 days ago by hasienda

  • Trac Release set to 0.11

Add Comment

Modify Ticket

Action
as accepted The owner will remain hasienda.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.