Modify

Opened 14 months ago

Closed 13 months ago

Last modified 13 months ago

#11252 closed defect (fixed)

Cannot hide "hours" main nav

Reported by: jaredbownds Owned by: rjollos
Priority: normal Component: TracHoursPlugin
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

This is a great plugin. Currently in trac 1.0.1 I am unable to hide the "hours" tab from users who DO NOT have the TICKET_ADD_HOURS permissions. Can you please advise on an effective method to do so?

Attachments (0)

Change History (15)

comment:1 Changed 14 months ago by rjollos

It looks like we aren't doing the necessary permission checks in the INavigationContributor implementation. It will be straightforward to fix. Could I interest you in generating a patch?

comment:2 Changed 14 months ago by jaredbownds

If I were that technically inclined I would, but unfortunately I am not. Please however do let me know how I may be able to assist.

comment:3 Changed 14 months ago by rjollos

  • Status changed from new to assigned

I'll try to get this fixed today.

comment:4 Changed 14 months ago by jaredbownds

Any updates? Please let me know if I can be of assistance.

comment:5 Changed 14 months ago by rjollos

I think what we really need is a TICKET_VIEW_HOURS permission. If the user doesn't have TICKET_ADD_HOURS, they may still want the ability to view hours. I'll have to take a closer look though.

comment:6 Changed 14 months ago by jaredbownds

I was under the impression that is how this plugin is currently developed to work, if a user does not have TICKET_ADD_HOURS they are unable to see the "Hours" tab in the main nav AND add hours / change hours for any ticket.

Version 0, edited 14 months ago by jaredbownds (next)

comment:7 Changed 14 months ago by rjollos

Thanks for the feedback. I'm planning to finish up this ticket on the coming Saturday. I'll let you know if anything changes with regard to that.

comment:8 Changed 13 months ago by anonymous

Hi there. Any status updates?

comment:9 Changed 13 months ago by rjollos

I didn't get to this last weekend, though it's on my list for the coming weekend (along with #11275).

comment:10 Changed 13 months ago by rjollos

In 13356:

Require TICKET_VIEW_HOURS to access the path /hours. Refs #11252.

comment:11 Changed 13 months ago by rjollos

In 13357:

Fixed missing linebreak. Refs #11252.

comment:12 Changed 13 months ago by rjollos

In 13358:

Removed unnecessary permission check. Refs #11252.

comment:13 Changed 13 months ago by rjollos

I didn't have much time to spend on this, which partially accounts for the sloppiness of [13356-13358]. The changes could benefit from additional testing. Please report back if you can.

comment:14 Changed 13 months ago by jaredbownds

  • Resolution set to worksforme
  • Status changed from assigned to closed

The changes work perfectly. Thank you for implementing the new permission set and being so responsive to the feedback.

comment:15 Changed 13 months ago by rjollos

  • Resolution changed from worksforme to fixed

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.