Modify

Opened 13 months ago

Closed 13 months ago

Last modified 12 months ago

#11282 closed defect (fixed)

No clean copy of license file in source tree

Reported by: awilliam@… Owned by: rjollos
Priority: high Component: CondFieldsGenshiPlugin
Severity: normal Keywords: licensing
Cc: rjollos, awilliam@… Trac Release:

Description

The condfieldsgenshi plugin is licensed under BSD, but doesn't include a clean copy of the license in the source tree. It's in-lined in setup.py . This is a bit of a problem for binary packages because setup.py is not installed, so the binary package is missing a copy of the license. BSD explicitly requires a copy of the license in all "binary distributions".

Can a clean copy of the license be added to the source tree for packagers to include in their packages? Thanks.

See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text for details. I'm roadblocked from including the plugin in Fedora until this is resolved.

Attachments (0)

Change History (9)

comment:1 Changed 13 months ago by awilliam@…

  • Cc awilliam@… added

comment:2 in reply to: ↑ description Changed 13 months ago by rjollos

Replying to awilliam@…:

See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text for details. I'm roadblocked from including the plugin in Fedora until this is resolved.

That was interesting to read. Thanks for providing the reference.

One other small thing is that the copyright statements aren't consistent, or at least all authors should be listed together on consecutive lines.

I think that I've seen activity from Reinhard fairly recently, but if we don't hear back then I'm fine with adding a COPYING file and copying the license from setup.py. There's certainly no ambiguity in doing that.

comment:3 follow-up: Changed 13 months ago by awilliam@…

"That was interesting to read. Thanks for providing the reference."

Wow, you're one of those crazy lunatics like me who finds licensing interesting :)

"One other small thing is that the copyright statements aren't consistent"

Indeed. I _suspect_ Reinhard templated his plugin off one written by Stephen and forgot to change that line. If you google "Copyright (c) 2008, Stephen Hansen" you find several trac plugin setup.py files containing that line. Also, they all leave the placeholder "<ORGANIZATION>" in the license text where you're meant to put your name or company or whatever, including this one :) (damnit trac stop wikifying "one")

Thanks for the quick response! I'm trying to keep up momentum working on https://fedorahosted.org/fedora-badges and I need this plugin to set up the separate workflows for new badges and bug reports, but I can wait a bit and see if Reinhard's around.

comment:4 in reply to: ↑ 3 Changed 13 months ago by rjollos

Replying to awilliam@…:

Wow, you're one of those crazy lunatics like me who finds licensing interesting :)

Hah, well. I am interested, but not because I enjoy licensing per se. I have been slowly working on developing some best practices guidelines for packaging and distributing plugins on trac-hacks, so that served as a good reference I could use in developing the guidelines.

Feel free to ping me again if we don't hear in a few days and I'll take care of the change,

comment:5 Changed 13 months ago by awilliam@…

We haven't heard from him yet - could you possibly do the change and maybe cut a new release, rjollos? (new release not necessary, I can package a cvs commit if need be). thanks!

comment:6 Changed 13 months ago by Reinhard

Hi guys,

I am reading your mail but I am under big pressure in the moment (recently have to screw and correct a big PHP project ... thanks for the condolence ;-). So it would be nice if you could correct the license problem. I plan to be alive again before end of October :-)

Best

Reinhard

comment:7 Changed 13 months ago by rjollos

  • Owner changed from Reinhard to rjollos
  • Status changed from new to assigned

Sure, I'll make the changes today :)

comment:8 Changed 13 months ago by rjollos

  • Resolution set to fixed
  • Status changed from assigned to closed

In 13364:

Moved license text to COPYING file. Fixes #11282.

comment:9 Changed 12 months ago by awilliam@…

Thanks! Fedora package is now going ahead.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.