The components are duplicated in admin page

[Tetsuya Morimoto]

The components are duplicated on Components page in admin panel when DefaultCCAdmin is enabled.

My environment are:

• DefaultCc-0.3dev_r13333
• Trac-1.0.2dev_r12281

It seems that the save process is fine, this bug is only for display in admin page.

• ​http://trac-hacks.org/browser/defaultccplugin/trunk/defaultcc/admin.py#L141

141                     filter = filter.append(tag.tr(tag.td(tag.input(type='checkbox', name='sel', value=comp.name), class_='sel'),
142                                                   tag.td(tag.a(comp.name, href=req.href.admin('ticket', 'components') + '/' + comp.name), class_='name'),
143                                                   tag.td(comp.owner, class_='owner'),
144                                                   tag.td(default_tag, class_='default'),
145                                                   tag.td(default_cc, class_='defaultcc')))

[Ryan J Ollos]

It appears this might somehow be due to ​[trac 11919]. Previously, it seems that exhausting the iterator would cause the table to not be rendered, therefore the original author recreated the entire table in Genshi. After 1.0.2dev-r11919, the original table and recreated table are rendered.

[Ryan J Ollos]

In 13445:

0.3dev: After Trac 1.0.2dev-r11919, duplicate entries would appear in the table. Fixes #11423,

With components having been cast to a list in the template data dictionary, it has been possible to simplify the filter_stream implementation. It is no longer necessary to recreate the entire table, rather we can just append the "defaultcc" data to the table rows.

[Ryan J Ollos]

I fixed some other issues in [13446:13449]. Please let me know if you spot any problems.

[Tetsuya Morimoto]

I updated from trunk and confirmed it works well. Thank you for quick response!