Modify

Opened 8 years ago

Closed 5 years ago

Last modified 18 months ago

#1145 closed enhancement (fixed)

[Patch] Start on sunday option

Reported by: josestefan Owned by: mgood
Priority: normal Component: WikiCalendarMacro
Severity: minor Keywords:
Cc: Trac Release: 0.10

Description

the calander should have the option of starting on Sundays.

Attachments (1)

wikicalendar-locale.diff (1.3 KB) - added by JoshuaH 5 years ago.
Make WikiCalendar respect the locale setting

Download all attachments as: .zip

Change History (5)

Changed 5 years ago by JoshuaH

Make WikiCalendar respect the locale setting

comment:1 Changed 5 years ago by JoshuaH

I've attached a patch which makes it respect the locale setting. This may only work on Unix since it uses popen(). Also, at least if you're running Trac via Apache 2 and mod_fcgid, you'll need to add an explicit LANG setting to your DefaultInitEnv variables because mod_fcgid clears the environment except for whatever you specify in those variables.

comment:2 Changed 5 years ago by rjollos

  • Summary changed from start on sunday option to [Patch] Start on sunday option

comment:3 Changed 5 years ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

(In [7324]) Use locale setting to determine if week should start on Sunday or Monday. Thanks for JoshuaH for the patch. Closes #1145

comment:4 Changed 18 months ago by hasienda

(In [12989]) WikiCalendarMacro: Add optional week numbers, refs #1145, #7639 and #8175.

Rationale and constraints of current implementation:

  • support any calendar per instance (use 'w' key-word) - no dependencies
  • use basic start-of-week negotiation, if Babel is not installed
  • use auto-negotiation for locale-aware Trac versions (since Trac 0.12)
  • use advanced locale detection (similar to Trac 1.0.2)

Because I've found an issue with week number calculation in Babel,
this plugin does it on its own for now.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.