Modify

Opened 7 months ago

Closed 7 months ago

#11491 closed task (fixed)

Adoption Request for WantedPagesPlugin

Reported by: glinders Owned by: jfrancis
Priority: normal Component: WantedPagesMacro
Severity: normal Keywords:
Cc: Trac Release:

Description

I would like to adopt WantedPagesPlugin

Attachments (0)

Change History (10)

comment:1 Changed 7 months ago by rjollos

This should really be WantedPagesMacro, so I'm going to rename it now.

Last edited 7 months ago by rjollos (previous) (diff)

comment:2 Changed 7 months ago by rjollos

  • Component changed from WantedPagesPlugin to WantedPagesMacro

Renaming plugin from WantedPagesPlugin to WantedPagesMacro.

comment:3 Changed 7 months ago by rjollos

Page content moved to WantedPagesMacro and redirect added at WantedPagesPlugin.

comment:4 Changed 7 months ago by rjollos

  • Type changed from defect to task

comment:5 Changed 7 months ago by rjollos

In 13565:

Fixes #8726, Refs #11491:

  • Bumped version to 0.4dev.
  • Modified entry point. Plugin is now enabled as wantedpages.* = enabled.
  • Renamed from WantedPagesPlugin to WantedPagesMacro.
  • Modified test cases to use trac.wiki.formatter.
  • PEP-0008 changes.
  • Use WikiMacroBase as base class and IWikiMacroProvider interface from Trac 0.11 and later.

comment:6 Changed 7 months ago by rjollos

comment:7 Changed 7 months ago by rjollos

Okay, changes that I had planned are completed. Please let me know if you spot any issues.

One thought I had, maybe we can use rules from parser.py rather than trying to redefine them in the plugin code. That might allow the plugin to implicitly handle changes such as #9639 and #10820.

comment:8 Changed 7 months ago by rjollos

glinders: In case you aren't familiar with running the unit tests, I just wanted to mention that you can execute them in a few different ways:

  • $ PYTHONPATH=. python setup.py test
  • $ PYTHONPATH=. python -m wantedpages.tests.__init__
  • $ PYTHONPATH=. python ./wantedpages/tests/__init__.py

It should be simple to add test cases for any issues you fix, but if you run into trouble please feel free to CC me on the ticket. The cases in which you need to provide a particular context can be slightly more complex.

comment:9 Changed 7 months ago by jfrancis

Hi Guys, I give my blessing for someone to take over maintenance of this project. Being absent for, oh, 2-3 years does not make for a great maintainer. Good luck

comment:10 Changed 7 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed

glinders is now the maintainer. Please complete the steps at AdoptingHacks#AfterAdoptingaHack.

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from jfrancis. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.