Modify

Opened 9 months ago

Closed 7 months ago

#11551 closed defect (fixed)

WikiWords in event titles lead to AttributeError

Reported by: lucid Owned by: lucid
Priority: normal Component: WeekPlanPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

  File "trac\web\main.py", line 497, in _dispatch_request       dispatcher.dispatch(req)
  File "trac\web\main.py", line 214, in dispatch                resp = chosen_handler.process_request(req)
  File "weekplan\core.py", line 56, in process_request          self._send_event(req, event)
  File "weekplan\core.py", line 85, in _send_event              self._send_json(req, event.serialized(self.env, context))
  File "weekplan\model.py", line 35, in serialized              'title_html': format_to_html(env, context, self.title),
  File "trac\wiki\formatter.py", line 1546, in format_to_html   return HtmlFormatter(env, context, wikidom).generate(escape_newlines)
  File "trac\wiki\formatter.py", line 1501, in generate         escape_newlines)
  File "trac\wiki\formatter.py", line 1283, in format           result = re.sub(self.wikiparser.rules, self.replace, line)
  File "lib\re.py", line 151, in sub                            return _compile(pattern, flags).sub(repl, string, count)
  File "trac\wiki\formatter.py", line 1201, in replace          replacement = self.handle_match(fullmatch)
  File "trac\wiki\formatter.py", line 1194, in handle_match     return external_handler(self, match, fullmatch)
  File "trac\wiki\api.py", line 355, in wikipagename_link       self.ignore_missing_pages, match)
  File "trac\wiki\api.py", line 412, in _format_link            pagename = self._resolve_scoped_name(pagename, referrer)
  File "trac\wiki\api.py", line 446, in _resolve_scoped_name    referrer = referrer.split('/')
AttributeError: 'NoneType' object has no attribute 'split'

This code in Trac: trac:source:tags/trac-1.0/trac/wiki/api.py?marks=404-406#L395
is not compatible with this code in the WeekPlanPlugin plugin: source:weekplanplugin/trunk/weekplan/core.py@13632:84#L83

The resource realm could be changed to something other than wiki, e.g. weekplan.

Attachments (0)

Change History (1)

comment:1 Changed 7 months ago by lucid

  • Resolution set to fixed
  • Status changed from new to closed

In 13766:

WeekPlanPlugin: Use weekplan realm in wiki rendering context to avoid AttributeError when WikiWords are used. (fix #11551)
Hopefully we won't run into problems with this because the weekplan resource realm is not actually implemented.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.