Changes between Initial Version and Version 1 of Ticket #11627, comment 9


Ignore:
Timestamp:
Mar 18, 2014, 9:19:24 PM (10 years ago)
Author:
Ryan J Ollos
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11627, comment 9

    initial v1  
    22> As best I can tell, it manages to not re-add the anchor each time.
    33
    4 The issue I saw was not with re-adding the anchor. The issue is when a second call to `enableFolding` adds a link element, it creates it with `id=no1`, restarting the numbering. Having duplicated `id` elements is violation of the HTML spec. Given that, its clear that `enableFolding` was not designed to be called more than once on a page.
     4The issue I saw was not with re-adding the anchor. The issue is when a second call to `enableFolding` adds a link element, it creates it with `id=no1`, restarting the numbering. Having duplicated `id` elements is violation of the HTML spec. This is in addition to the problem you noted about the folding behavior not functioning correctly. I mentioned the issue with the `id` attributes because it makes it clear that `enableFolding` was not designed to be called more than once on a page.
    55
    66Anyway, your patch will mess-up the "snap-to" behavior on several pages. Whether you care about that or not I don't know.