Modify

Opened 6 years ago

Closed 11 months ago

#1605 closed defect (fixed)

Preserve wiki formatting within colored text

Reported by: anonymous Owned by: rjollos
Priority: normal Component: ColorMacro
Severity: normal Keywords:
Cc: chris@… Trac Release: 0.11

Description

with current macro, when I tried like this

Color(white,blue,Research?

It should change only color, I suppose. But it wasn't.
Only changing the color is desirable without effecting any wiki formatting.
Is is possbile to do this?
Thank you very much.

Attachments (4)

ColorMacro_1605.patch (2.1 KB) - added by framay 20 months ago.
possible patch for this ticket
ColorMacro_1605_processor.patch (3.8 KB) - added by framay 20 months ago.
another patch: it is now also usable as WikiProcessor
ColorMacro_1605_processor2.patch (4.3 KB) - added by framay 20 months ago.
another patch, which have rewritten most of the plugins code
ColorMacro.py (3.8 KB) - added by framay 20 months ago.
Python file, identical when merging with ColorMacro_1605_processor2.patch

Download all attachments as: .zip

Change History (13)

comment:1 Changed 5 years ago by diroussel

That should be possible as the TracWikiMacros page says we can do this:

  text = "whatever wiki markup you want, even containing other macros"
  # Convert Wiki markup to HTML, new style
  out = StringIO()
  Formatter(self.env, formatter.context).format(text, out)
  return Markup(out.getvalue())

comment:3 Changed 2 years ago by rjollos

  • Summary changed from keeping all formattings and changing only colors to Preserve wiki formatting within colored text

#7696 closed as a duplicate.

comment:4 Changed 2 years ago by anonymous

  • Cc chris@… added

Changed 20 months ago by framay

possible patch for this ticket

comment:5 Changed 20 months ago by framay

I uploaded a possible solution for this ticket. All simple Wiki formatting should work (like bold, italic, links to tickets, etc.). But it seems that no macros are working.

So this example is working with that patch:

[[Color(lime,None,wiki,This is ''just'' an '''simple''' test, for more info see #7696 or TitleIndex)]]

This example however is not working (it just prints "recent changes: [[RecentChanges(,3" in lime background):

[[Color(lime,None,wiki,recent changes: [[RecentChanges(,3)]])]]

Changed 20 months ago by framay

another patch: it is now also usable as WikiProcessor

comment:6 Changed 20 months ago by framay

I added another possible patch, which allows using it as processor. And in that you can use wiki processors and wiki formatting.

Changed 20 months ago by framay

another patch, which have rewritten most of the plugins code

Changed 20 months ago by framay

Python file, identical when merging with ColorMacro_1605_processor2.patch

comment:7 Changed 20 months ago by framay

I saw just now, that the functionality, which is provided by ColorMacro is already implemented as default in Trac, see http://trac.edgewall.org/wiki/WikiHtml#HowtoUseDivSpan. And using span- and div-macro is even more powerful.

comment:8 Changed 11 months ago by rjollos

  • Owner changed from diroussel to rjollos

(In [11892]): Fixes #1605, #5651,

  • Use Genshi to construct span element.
  • Removed padding around span element.
  • Format wiki to html, allowing wiki markup to be used as the text argument to the Color macro.

comment:9 Changed 11 months ago by rjollos

  • Resolution set to fixed
  • Status changed from new to closed
  • Trac Release changed from 0.10 to 0.11

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.