id,summary,reporter,owner,description,type,status,priority,component,severity,resolution,keywords,cc,release 1727,adding a comment without a file doesn't work (fix included),tvolpini@…,Team5,"Trac version 0.10.3, !TracCodeReview version 2.0dev When I add a comment without attaching a file, the next dialog hangs at 'Loading...'. If I click 'Add a new Comment' in this dialog, the next dialog contains a trac internal error with the following traceback: {{{ Traceback (most recent call last): File ""/var/lib/python-support/python2.4/trac/web/main.py"", line 387, in dispatch_request dispatcher.dispatch(req) File ""/var/lib/python-support/python2.4/trac/web/main.py"", line 237, in dispatch resp = chosen_handler.process_request(req) File ""build/bdist.linux-x86_64/egg/codereview/peerReviewCommentCallback.py"", line 44, in process_request File ""build/bdist.linux-x86_64/egg/codereview/peerReviewCommentCallback.py"", line 117, in createComment AttributeError: 'unicode' object has no attribute 'filename' }}} Adding {{{ if req.args.has_key('attachFilecheckbox'): checked = req.args['attachFilecheckbox'] if checked: }}} before the {{{ if req.args.has_key('FileUp'): }}} line (and fixing indentation, obviously) fixes the problem for me. ",defect,closed,normal,PeerReviewPlugin,normal,fixed,,,0.10