Modify

Opened 8 years ago

Last modified 3 years ago

#186 new enhancement

[Patch] Inline CSS

Reported by: coderanger Owned by: rjollos
Priority: normal Component: LastModifiedMacro
Severity: normal Keywords:
Cc: HorsePunchKid Trac Release: 0.10

Description

For a short piece of CSS like you show for your macro, it is usually eaisier to inline it into a style element. Alternatively you can repackage this as a plugin, which can provide its own CSS.

Attachments (1)

convert_to_plugin_inline_css_patch.diff (5.8 KB) - added by BladeHawke 8 years ago.
Not exactly really a patch, more like the source for the 0.10 version :p

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by HorsePunchKid

  • Status changed from new to assigned
  • Trac Release set to 0.8

comment:2 Changed 8 years ago by HorsePunchKid

  • Trac Release changed from 0.8 to 0.9

I would be willing to convert it to a plugin if the overhead is relatively small; I don't know anything about the plugin architecture, though. Would this prevent your CSS for the macro from getting clobbered when you update your trac install?

comment:3 Changed 8 years ago by BladeHawke

  • Cc HorsePunchKid added
  • Owner changed from HorsePunchKid to BladeHawke
  • Status changed from assigned to new
  • Trac Release changed from 0.9 to 0.10

I'm going to give the conversion to plugin a shot. This has been sitting idle for a while.

Changed 8 years ago by BladeHawke

Not exactly really a patch, more like the source for the 0.10 version :p

comment:4 Changed 8 years ago by BladeHawke

  • Status changed from new to assigned

Alright, the patch really creates a new plugin for 0.10. It handles the issue for for #186 (though the CSS insertion needs refinement, it's brute forced in). Argument parsing has been completely reworked (would be nice to have a standardized parser ;p). It also handles the issue that is going to start to pop up as people transition to 0.10 and that is split_page_names. The plugin will work even with that option on, but the 0.9 macro will not (though it works as advertised in 0.10 without that option set).

Not sure if I should set the plugin up as a new hack or what, but here it is (sortof :p)

comment:5 Changed 4 years ago by rjollos

  • Owner changed from BladeHawke to rjollos
  • Status changed from assigned to new
  • Summary changed from Inline CSS to [Patch] Inline CSS

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.