Ticket #186 (assigned enhancement)

Opened 3 years ago

Last modified 2 years ago

Inline CSS

Reported by: coderanger Assigned to: BladeHawke (accepted)
Priority: normal Component: LastModifiedMacro
Severity: normal Keywords:
Cc: HorsePunchKid Trac Release: 0.10

Description

For a short piece of CSS like you show for your macro, it is usually eaisier to inline it into a style element. Alternatively you can repackage this as a plugin, which can provide its own CSS.

Attachments

convert_to_plugin_inline_css_patch.diff (5.8 kB) - added by BladeHawke on 09/29/06 04:39:19.
Not exactly really a patch, more like the source for the 0.10 version :p

Change History

04/14/06 17:37:11 changed by HorsePunchKid

  • release set to 0.8.
  • status changed from new to assigned.

04/14/06 17:49:32 changed by HorsePunchKid

  • release changed from 0.8 to 0.9.

I would be willing to convert it to a plugin if the overhead is relatively small; I don't know anything about the plugin architecture, though. Would this prevent your CSS for the macro from getting clobbered when you update your trac install?

09/28/06 01:22:58 changed by BladeHawke

  • cc set to HorsePunchKid.
  • owner changed from HorsePunchKid to BladeHawke.
  • status changed from assigned to new.
  • release changed from 0.9 to 0.10.

I'm going to give the conversion to plugin a shot. This has been sitting idle for a while.

09/29/06 04:39:19 changed by BladeHawke

  • attachment convert_to_plugin_inline_css_patch.diff added.

Not exactly really a patch, more like the source for the 0.10 version :p

09/29/06 04:46:20 changed by BladeHawke

  • status changed from new to assigned.

Alright, the patch really creates a new plugin for 0.10. It handles the issue for for #186 (though the CSS insertion needs refinement, it's brute forced in). Argument parsing has been completely reworked (would be nice to have a standardized parser ;p). It also handles the issue that is going to start to pop up as people transition to 0.10 and that is split_page_names. The plugin will work even with that option on, but the 0.9 macro will not (though it works as advertised in 0.10 without that option set).

Not sure if I should set the plugin up as a new hack or what, but here it is (sortof :p)

Add/Change #186 (Inline CSS)




Change Properties
Action