Modify

Opened 7 years ago

Closed 5 years ago

#2018 closed defect (fixed)

batchmodifyplugin creates Ticket object with id as str, not int, breaking convention

Reported by: thomasvs Owned by: CuriousCurmudgeon
Priority: normal Component: BatchModifyPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

This caused my ITicketChangeListener to break. I grepped through trac source code and everywhere Ticket objects are created with an int.

I guess this should also be explicitly documented as such, there's no point in allowing both IMO.

Attaching patch.

Attachments (1)

batchmod.patch (489 bytes) - added by thomasvs 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by thomasvs

comment:1 Changed 6 years ago by bill.coffman@…

Pls note, the patch of thomasvs fixed my error. Thanks Thomas!

I have timingandestimationplugin, and just upgraded from 0.10 to 0.11.1. Batch modifications would work correctly on the first change only, and then stop with an internal error, TypeError: int argument required, and a stack trace.

Although this patch was created for 0.10, it fixes my problem with 0.11.1, and BatchModifyPlugin-0.2.

I strongly recommend the author incorporates this patch (or equivalent) into his code.

comment:2 Changed 5 years ago by CuriousCurmudgeon

  • Owner changed from ashwin_phatak to CuriousCurmudgeon
  • Status changed from new to assigned

comment:3 Changed 5 years ago by CuriousCurmudgeon

(In [7416]) refs #2018

  • Cast id to int when creating Ticket object. Thanks to thomasvs.

comment:4 Changed 5 years ago by CuriousCurmudgeon

  • Resolution set to fixed
  • Status changed from assigned to closed
  • Trac Release changed from 0.10 to 0.11

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.