Modify

Opened 7 years ago

Closed 7 years ago

#2035 closed defect (fixed)

Reply to a comment does not work

Reported by: c.posluschni@… Owned by: djeebus
Priority: high Component: PeerReviewPlugin
Severity: critical Keywords: Reply
Cc: Trac Release: 0.10

Description

Reply to a comment does not work in IE and Firefox.

JavaScript Errorlog:

Error: missing ) after argument list
Sourcefile: javascript:addComment(u'25', u'16', 89)
Row: 1, Column: 12
SourceCode:
addComment(u'25', u'16', 89)

If I apply javascript:addComment(25, 16, 89) to the address bar of my browser the
"Reply To Comment on Line 25" - Dialog appears.

So I suppose the change in Line 200 (Rev. 2577) caused this error.

Rev. 717 (Line 201)

html += "<a href=\"javascript:addComment(" + LineNum + ", " + IDFile + ", " +  comment.IDComment + ")\">Reply</a></td></tr>" 

Rev. 2577 (Line 200)

html += "<a href=\"javascript:addComment(" + `LineNum` + ", " + `IDFile` + ", " +  `comment.IDComment` + ")\">Reply</a></td></tr>" 

Attachments (0)

Change History (1)

comment:1 Changed 7 years ago by djeebus

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for pointing this out! It's been taken care of, and a couple others as well. Apparently I was using the wrong method to convert from a Long to a String. Enjoy!

Add Comment

Modify Ticket

Action
as closed .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from djeebus. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.