Ticket #224 (new enhancement)

Opened 3 years ago

Last modified 1 month ago

Attach changeset to Code Review

Reported by: shrtminded Assigned to: sontek
Priority: high Component: PeerReviewPlugin
Severity: major Keywords:
Cc: alexhalf@gmail.com, kmacinni@hotmail.com, jgeller@ebscohost.com Trac Release: 0.10

Description

It would be nice to have the ability to attach a changeset to a code review. This way it will automatically pull in all the files that were changed and the line numbers in to the code review.

Attachments

Change History

07/20/06 07:50:53 changed by anonymous

  • release set to 0.8.

I'd like to add my vote for this - it's impractical to enter each range of changed lines in each file. The changeset already has this information. Even better than a changeset might be to be able to select a range of revision numbers related to a folder - similar to the TortoiseSVN merge screen which allows you to merge between branches.

11/23/06 15:59:10 changed by anonymous

As an extension it'll be usefull to enter several files or even directory to make a full review (no need to enter the lines), for example for a review of a whole component

So at least a changeset will be A LOT usefull ! So I vote for this enhancement

08/18/07 18:33:18 changed by sontek

  • owner changed from Team5 to sontek.
  • priority changed from normal to high.
  • severity changed from normal to major.
  • release changed from 0.8 to 0.10.

This is a great idea

05/08/08 04:26:25 changed by anonymous

  • cc set to alexhalf@gmail.com.

06/24/08 17:14:15 changed by iain@exolete.com

Has anyone made any progress on this ticket? Is anyone planning to? I've seen this mentioned as a blocker to people using this plugin in a few places (e.g. here); it is certainly the main problem I would have with using it.

From a quick look at the code, the work required to get a useable solution shouldn't be very hard. Here's what I propose. We simply add a "create review from changeset" option to the "create new code review" page, which has two user inputs: a text box for the revision number, and a "add files from this changeset" button. When the user presses the button, the data for that changeset is retrieved and entered in the page. In /peerreviewplugin/branches/2.2-dev/codereview/peerReviewNew.py, it looks like the data would be added as is done around lines 89 and 144, and changeset data could be retrieved using methods from here

repos.get_changesets(old,new)

With line numbers worked out as _content_changes here.

Indeed, line numbers would be optional, and a first step would be just to retrieve the file names. This would give minimal working functionality, and quickly. There are a few things I don't know until I try it:

  • What to do if (and whether to allow) the user adds data from multiple changesets? Should the diffs merge?
  • How/whether to link a review back to the changeset it was reviewing.
  • How well it would work with non-svn repositories

I only installed the PeerReviewPlugin earlier today so I'm no expert, and I'm not sure if this is a reasonable design. Any thoughts?

08/12/08 10:27:56 changed by valent@tut.by

I'm very interested in this feature aswell. Is it possible to resolve attaching changeset to code review in any way ?

08/27/08 18:17:33 changed by anonymous

  • cc changed from alexhalf@gmail.com to alexhalf@gmail.com, kmacinni@hotmail.com.

09/10/08 10:47:29 changed by anonymous

  • cc changed from alexhalf@gmail.com, kmacinni@hotmail.com to alexhalf@gmail.com, kmacinni@hotmail.com, jgeller@ebscohost.com.

Add/Change #224 (Attach changeset to Code Review)




Change Properties
Action