Modify

Opened 7 years ago

Closed 7 years ago

#2304 closed enhancement (fixed)

Drop the immediate mode checkbox

Reported by: martin@… Owned by: dalius
Priority: high Component: AuthOpenIdPlugin
Severity: minor Keywords:
Cc: Trac Release: 0.11

Description

Immediate mode is supposed to be initiated by some software so that user interaction would not be needed and the fallback would be to go with normal associateion requests. Thus it does not make much sense to have it as a checkbox.

As a second issue - instead of getting back to the logi nscreen after a successful login, one should be directed to the main page of the trac probably.

Attachments (0)

Change History (5)

comment:1 Changed 7 years ago by anonymous

Instead there should be some quick introduction to OpenID and maybe a link to openid.net so that people would get some idea where to look and what to do.

comment:2 Changed 7 years ago by dalius

Proposal from anonymous looks like myopenid affiliate with link to what's myopenid. Martin's proposal is somewhat different and I find it really interesting and new. I believe it must be implemented.

comment:3 Changed 7 years ago by martin@…

  • Priority changed from normal to high

Actually I was also the anonymous person. A link to openid.net or some other neutral 'what the heck is OpenID and what the heck should i type here to get in' is very much needed - it has been a very discussed topic in the OpenID community that explanation work and marketing is the most important thing to concentrate on. Currently the OpenID plugin is OK if you know everything about OpenID but once you put it onto a public trac, people will get 'huh?' type of feelings. Even if they have heard and read a bit about OpenID.

I'm sure there are better ways to explain but this might be a good start.

The login problem (redirecting to main page) is actually a more important thing.

comment:4 Changed 7 years ago by anonymous

Here's a patch (on top of #2305 changes) to redirect to the main trac page on successful login

Index: authopenid.py
===================================================================
--- authopenid.py	(revision 2892)
+++ authopenid.py	(working copy)
@@ -302,7 +308,7 @@
                 req.session['name'] = reg_info['nickname']
             if reg_info and reg_info.has_key('email') and len(reg_info['email']) > 0:
                 req.session['email'] = reg_info['email']
-
+            req.redirect(req.abs_href())
         elif info.status == consumer.CANCEL:
             # cancelled
             message = 'Verification cancelled'

I hope it does not interfere with http://trac.edgewall.org/ticket/5064

About the immediate mode checkbox vs openid.net link - I believe it is a fair swap.

comment:5 Changed 7 years ago by dalius

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.